From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain Date: Thu, 12 Mar 2015 20:23:26 +0800 Message-ID: <5501853E.7050009@huawei.com> References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-9-git-send-email-wangyijing@huawei.com> <20150312013918.GC10949@google.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150312013918.GC10949@google.com> Sender: linux-ia64-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 8b3d245..2b1b998 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus) >> return bus->domain_nr; >> } >> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent); >> +void pci_host_assign_domain_nr(struct pci_host_bridge *host); > > I do not think this needs to be in include/linux/pci.h. It's called only > from drivers/pci/host-bridge.c, so at most, it needs to be in > drivers/pci/pci.h. > > Better still would be if the definition could be moved from > drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything > in a header file at all. This is a good idea, thanks. > >> #else >> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus, >> struct device *parent) >> { >> } >> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host) >> +{ >> +} >> #endif >> >> /* some architectures require additional setup to direct VGA traffic */ >> -- >> 1.7.1 >> > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Thu, 12 Mar 2015 12:23:26 +0000 Subject: Re: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain Message-Id: <5501853E.7050009@huawei.com> List-Id: References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-9-git-send-email-wangyijing@huawei.com> <20150312013918.GC10949@google.com> In-Reply-To: <20150312013918.GC10949@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bjorn Helgaas Cc: Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@vger.kernel.org, Liviu Dudau , Arnd Bergmann , Geert Uytterhoeven >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 8b3d245..2b1b998 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus) >> return bus->domain_nr; >> } >> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent); >> +void pci_host_assign_domain_nr(struct pci_host_bridge *host); > > I do not think this needs to be in include/linux/pci.h. It's called only > from drivers/pci/host-bridge.c, so at most, it needs to be in > drivers/pci/pci.h. > > Better still would be if the definition could be moved from > drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything > in a header file at all. This is a good idea, thanks. > >> #else >> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus, >> struct device *parent) >> { >> } >> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host) >> +{ >> +} >> #endif >> >> /* some architectures require additional setup to direct VGA traffic */ >> -- >> 1.7.1 >> > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com ([119.145.14.65]:51696 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbbCLMX4 (ORCPT ); Thu, 12 Mar 2015 08:23:56 -0400 Message-ID: <5501853E.7050009@huawei.com> Date: Thu, 12 Mar 2015 20:23:26 +0800 From: Yijing Wang MIME-Version: 1.0 To: Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-9-git-send-email-wangyijing@huawei.com> <20150312013918.GC10949@google.com> In-Reply-To: <20150312013918.GC10949@google.com> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-pci-owner@vger.kernel.org List-ID: >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 8b3d245..2b1b998 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus) >> return bus->domain_nr; >> } >> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent); >> +void pci_host_assign_domain_nr(struct pci_host_bridge *host); > > I do not think this needs to be in include/linux/pci.h. It's called only > from drivers/pci/host-bridge.c, so at most, it needs to be in > drivers/pci/pci.h. > > Better still would be if the definition could be moved from > drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything > in a header file at all. This is a good idea, thanks. > >> #else >> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus, >> struct device *parent) >> { >> } >> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host) >> +{ >> +} >> #endif >> >> /* some architectures require additional setup to direct VGA traffic */ >> -- >> 1.7.1 >> > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Thu, 12 Mar 2015 20:23:26 +0800 Subject: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain In-Reply-To: <20150312013918.GC10949@google.com> References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-9-git-send-email-wangyijing@huawei.com> <20150312013918.GC10949@google.com> Message-ID: <5501853E.7050009@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 8b3d245..2b1b998 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus) >> return bus->domain_nr; >> } >> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent); >> +void pci_host_assign_domain_nr(struct pci_host_bridge *host); > > I do not think this needs to be in include/linux/pci.h. It's called only > from drivers/pci/host-bridge.c, so at most, it needs to be in > drivers/pci/pci.h. > > Better still would be if the definition could be moved from > drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything > in a header file at all. This is a good idea, thanks. > >> #else >> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus, >> struct device *parent) >> { >> } >> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host) >> +{ >> +} >> #endif >> >> /* some architectures require additional setup to direct VGA traffic */ >> -- >> 1.7.1 >> > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbbCLMYB (ORCPT ); Thu, 12 Mar 2015 08:24:01 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:51696 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753030AbbCLMX4 (ORCPT ); Thu, 12 Mar 2015 08:23:56 -0400 Message-ID: <5501853E.7050009@huawei.com> Date: Thu, 12 Mar 2015 20:23:26 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v6 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain References: <1425868467-9667-1-git-send-email-wangyijing@huawei.com> <1425868467-9667-9-git-send-email-wangyijing@huawei.com> <20150312013918.GC10949@google.com> In-Reply-To: <20150312013918.GC10949@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index 8b3d245..2b1b998 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1327,11 +1327,15 @@ static inline int pci_domain_nr(struct pci_bus *bus) >> return bus->domain_nr; >> } >> void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent); >> +void pci_host_assign_domain_nr(struct pci_host_bridge *host); > > I do not think this needs to be in include/linux/pci.h. It's called only > from drivers/pci/host-bridge.c, so at most, it needs to be in > drivers/pci/pci.h. > > Better still would be if the definition could be moved from > drivers/pci/pci.c to drivers/pci/host-bridge.c so we wouldn't need anything > in a header file at all. This is a good idea, thanks. > >> #else >> static inline void pci_bus_assign_domain_nr(struct pci_bus *bus, >> struct device *parent) >> { >> } >> +static inline void pci_host_assign_domain_nr(struct pci_host_bridge *host) >> +{ >> +} >> #endif >> >> /* some architectures require additional setup to direct VGA traffic */ >> -- >> 1.7.1 >> > > . > -- Thanks! Yijing