From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vince Hsu Subject: Re: [PATCH v2 17/17] soc/tegra: remove lagacy powergate APIs Date: Thu, 12 Mar 2015 21:11:52 +0800 Message-ID: <55019098.3020901@nvidia.com> References: <1426162518-7405-1-git-send-email-vinceh@nvidia.com> <1426162518-7405-18-git-send-email-vinceh@nvidia.com> <20150312124501.GA632@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate15.nvidia.com ([216.228.121.64]:9860 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbbCLNNp (ORCPT ); Thu, 12 Mar 2015 09:13:45 -0400 In-Reply-To: <20150312124501.GA632@ulmo> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Thierry Reding Cc: pdeschrijver@nvidia.com, swarren@wwwdotorg.org, gnurou@gmail.com, jroedel@suse.de, p.zabel@pengutronix.de, mturquette@linaro.org, pgaikwad@nvidia.com, sboyd@codeaurora.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, tbergstrom@nvidia.com, airlied@linux.ie, bhelgaas@google.com, tj@kernel.org, arnd@arndb.de, robh@kernel.org, will.deacon@arm.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Hi, On 03/12/2015 08:45 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Mar 12, 2015 at 08:15:18PM +0800, Vince Hsu wrote: >> We switch to generic power domain now. So remove the legacy functions. >> >> Signed-off-by: Vince Hsu >> --- >> drivers/soc/tegra/pmc.c | 68 ------------------------------------------------- >> include/soc/tegra/pmc.h | 22 ---------------- >> 2 files changed, 90 deletions(-) > I don't think we can do this. What if somebody updates their kernel but > not the DTB? In that case they'll end up with drivers that don't enable > power partitions but at the same time the powergate driver won't enable > them either because it is missing the corresponding nodes in the DTB. You're right. > > What we'll have to do is probably keep the code that enables the power > partitions and make it conditional on the power domains somehow. Is > there a way to determine at runtime whether a device has been attached > to a power domain? > Yes, we can check if a power domain is bound to the GPD by DT in the legacy powergate code. Thanks, Vince From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinceh@nvidia.com (Vince Hsu) Date: Thu, 12 Mar 2015 21:11:52 +0800 Subject: [PATCH v2 17/17] soc/tegra: remove lagacy powergate APIs In-Reply-To: <20150312124501.GA632@ulmo> References: <1426162518-7405-1-git-send-email-vinceh@nvidia.com> <1426162518-7405-18-git-send-email-vinceh@nvidia.com> <20150312124501.GA632@ulmo> Message-ID: <55019098.3020901@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 03/12/2015 08:45 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Mar 12, 2015 at 08:15:18PM +0800, Vince Hsu wrote: >> We switch to generic power domain now. So remove the legacy functions. >> >> Signed-off-by: Vince Hsu >> --- >> drivers/soc/tegra/pmc.c | 68 ------------------------------------------------- >> include/soc/tegra/pmc.h | 22 ---------------- >> 2 files changed, 90 deletions(-) > I don't think we can do this. What if somebody updates their kernel but > not the DTB? In that case they'll end up with drivers that don't enable > power partitions but at the same time the powergate driver won't enable > them either because it is missing the corresponding nodes in the DTB. You're right. > > What we'll have to do is probably keep the code that enables the power > partitions and make it conditional on the power domains somehow. Is > there a way to determine at runtime whether a device has been attached > to a power domain? > Yes, we can check if a power domain is bound to the GPD by DT in the legacy powergate code. Thanks, Vince From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754543AbbCLNNq (ORCPT ); Thu, 12 Mar 2015 09:13:46 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9860 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753787AbbCLNNp (ORCPT ); Thu, 12 Mar 2015 09:13:45 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 12 Mar 2015 06:12:08 -0700 Message-ID: <55019098.3020901@nvidia.com> Date: Thu, 12 Mar 2015 21:11:52 +0800 From: Vince Hsu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 17/17] soc/tegra: remove lagacy powergate APIs References: <1426162518-7405-1-git-send-email-vinceh@nvidia.com> <1426162518-7405-18-git-send-email-vinceh@nvidia.com> <20150312124501.GA632@ulmo> In-Reply-To: <20150312124501.GA632@ulmo> X-Originating-IP: [10.19.108.63] X-ClientProxiedBy: HKMAIL102.nvidia.com (10.18.16.11) To HKMAIL104.nvidia.com (10.18.16.13) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/12/2015 08:45 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, Mar 12, 2015 at 08:15:18PM +0800, Vince Hsu wrote: >> We switch to generic power domain now. So remove the legacy functions. >> >> Signed-off-by: Vince Hsu >> --- >> drivers/soc/tegra/pmc.c | 68 ------------------------------------------------- >> include/soc/tegra/pmc.h | 22 ---------------- >> 2 files changed, 90 deletions(-) > I don't think we can do this. What if somebody updates their kernel but > not the DTB? In that case they'll end up with drivers that don't enable > power partitions but at the same time the powergate driver won't enable > them either because it is missing the corresponding nodes in the DTB. You're right. > > What we'll have to do is probably keep the code that enables the power > partitions and make it conditional on the power domains somehow. Is > there a way to determine at runtime whether a device has been attached > to a power domain? > Yes, we can check if a power domain is bound to the GPD by DT in the legacy powergate code. Thanks, Vince