From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V13 3/7] xen/arm: Allow hypervisor access to mem_access protected pages Date: Thu, 12 Mar 2015 13:43:08 +0000 Message-ID: <550197EC.5060803@linaro.org> References: <1425677073-13729-1-git-send-email-tklengyel@sec.in.tum.de> <1425677073-13729-4-git-send-email-tklengyel@sec.in.tum.de> <55019382.4040108@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: wei.liu2@citrix.com, Ian Campbell , Stefano Stabellini , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, stefano.stabellini@citrix.com, Jan Beulich , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 12/03/15 13:38, Tamas K Lengyel wrote: > > + if ( flag == GV2M_WRITE ) > > + { > > + switch ( t ) > > + { > > + case p2m_ram_rw: > > > + case p2m_iommu_map_rw: > > + case p2m_map_foreign: > > + case p2m_grant_map_rw: > > + case p2m_mmio_direct: > > We disallow guest copy from the above 4 types via get_page_from_gva. So > I'm not sure if it's worth to check them here. > > > You mean get_page_from_gva only works for p2m_ram_rw type? Is this the > case for GV2M_READ as well? Yes, currently p2m_ram_rw is the only type bound to a struct page. -- Julien Grall