From mboxrd@z Thu Jan 1 00:00:00 1970 From: yakir Subject: Re: [PATCH v4 02/15] drm: bridge/dw_hdmi: wrap irq control in fucntions Date: Thu, 12 Mar 2015 22:54:42 +0800 Message-ID: <5501A8B2.205@rock-chips.com> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425176927-1784-1-git-send-email-ykk@rock-chips.com> <1426155862.14455.19.camel@pengutronix.de> <5501A34A.6050105@rock-chips.com> <1426171263.14455.58.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1362458971==" Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.131]) by gabe.freedesktop.org (Postfix) with ESMTP id F09D26E9BA for ; Thu, 12 Mar 2015 07:55:56 -0700 (PDT) In-Reply-To: <1426171263.14455.58.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: Fabio Estevam , mmind00@googlemail.com, marcheu@chromium.org, Greg Kroah-Hartman , dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, Russell King , Andy Yan List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1362458971== Content-Type: multipart/alternative; boundary="------------010608060403050909060900" This is a multi-part message in MIME format. --------------010608060403050909060900 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Philipp, On 2015=E5=B9=B403=E6=9C=8812=E6=97=A5 22:41, Philipp Zabel wrote: > Hi Yakir, > > Am Donnerstag, den 12.03.2015, 22:31 +0800 schrieb yakir: >> Hi Philipp, >> >> On 2015=E5=B9=B403=E6=9C=8812=E6=97=A5 18:24, Philipp Zabel wrote: >>> Hi Yakir, >>> >>> Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang: >>>> Wrap irq control in functions, and then we can call in >>>> dw_hdmi_bind/dw_hdmi_unbind/dw_hdmi_resume/dw_hdmi_suspend >>>> functions. >>>> >>>> Signed-off-by: Yakir Yang >>> [...] >> Sorry, I can not understand this comment. could you please talk more >> detail about this one. >> >> Thank you very much :) > I use "[...]" as a sign that I removed parts from the quoted email, lik= e > this: > > [...] Okay, thanks for your explanation :) >>> Here you remove code added in the previous patch. >>> It would be better to just apply patch 2 first and then rebase patch = 1 >>> on top of it. >> Thanks, I will reorder patch 1 & patch 2, in next vesion :) > regards > Philipp > regards :) Yakir > > --------------010608060403050909060900 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Philipp,

On 2015=E5=B9=B403=E6=9C=8812=E6=97=A5= 22:41, Philipp Zabel wrote:

Hi Yakir,

Am Donnerstag, den 12.03.2015, 22:31 +0800 schrieb yakir:

Hi Philipp,

On 2015=E5=B9=B403=E6=9C=8812=E6=97=A5 18:24, Philipp Zabel wrote:

Hi Yakir,

Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang:

Wrap irq control in functions, and then we can=
 call in
dw_hdmi_bind/dw_hdmi_unbind/dw_hdmi_resume/dw_hdmi_suspend
functions.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>

[...]

Sorry, I can not understand this comment. could yo=
u please talk more=20
detail about this one.

Thank you very much  :)

I use "[...]" as a sign that I removed parts from the quoted email, like
this:

[...]

Okay, thanks for your explanation=C2=A0 :)

Here you remove code added in the previous patch=
.
It would be better to just apply patch 2 first and then rebase patch 1
on top of it.

Thanks,  I will reorder patch 1 & patch 2, in next vesion   :)

regards
Philipp

regards :)
Yakir

--------------010608060403050909060900-- --===============1362458971== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1362458971==--