All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emeric Vigier <emeric.vigier@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] Makefile: add target to clean targetfs
Date: Thu, 12 Mar 2015 10:56:15 -0400	[thread overview]
Message-ID: <5501A90F.5040505@savoirfairelinux.com> (raw)
In-Reply-To: <CA+TH9VkgCo3n_SKFiSZt7Q2h5nYhMa-G25bqzto6C0op__TZxA@mail.gmail.com>

On 15-03-12 04:32 AM, Angelo Compagnucci wrote:
> Hi Baruch,
>
> 2015-03-11 9:58 GMT+01:00 Baruch Siach <baruch@tkos.co.il>:
>> Hi Angelo,
>>
>> On Wed, Mar 11, 2015 at 09:22:49AM +0100, Angelo Compagnucci wrote:
>>> I submitted a couple of patches some times ago, but they was rejected
>>> because potentially dangerous for users[1][2].
>>> So probably you will not have that much luck with this patch.
>>>
>>> [1] http://lists.busybox.net/pipermail/buildroot/2014-July/101963.html
>>> [2] http://lists.busybox.net/pipermail/buildroot/2014-July/103143.html
>>
>> Well, it is not me suggesting this patch, it is Emeric Vigier. But yes, one of
>> our clients asked for this functionality, so I really want this patch applied.
>>
>> As for previous rejections, the response of ThomasP[1] and Arnout[2] seems to
>> indicate that they would be willing to accept this functional addition
>> provided that it is (1) properly documented[1], and (2) prints a "big fat
>> warning"[2]. Something like Thomas' scenario description[3] should be added to
>> the documentation part of this patch.
>>
>> Thanks for reminding us this previous discussion.
>>
>> [1] http://lists.busybox.net/pipermail/buildroot/2014-July/101966.html
>>
>> [2] http://lists.busybox.net/pipermail/buildroot/2014-July/102064.html
>>
>> [3] http://lists.busybox.net/pipermail/buildroot/2014-July/101941.html
>
> I have my patch on top of my git rebase everytime I pull from master,
> so I will be veeeeery glad if you can have it upstreamed!
> I love so much the option to clean the target that I use it everyday!

Indeed, it seems I had the same scenario in mind as you when you 
submitted your patch. Let me add your signed-off to my patch, and we'll 
both push strong to have it upstreamed!

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>

I'll send a v3 soon.

>
> Sincerely, Angelo
>
>>
>> baruch
>>
>> --
>>       http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
>> =}------------------------------------------------ooO--U--Ooo------------{=
>>     - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
>

Emeric

  reply	other threads:[~2015-03-12 14:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  0:25 [Buildroot] [PATCH 1/1] Makefile: add target to clean targetfs Emeric Vigier
2015-03-10  4:45 ` Baruch Siach
2015-03-10 14:56   ` Emeric Vigier
2015-03-10 15:17     ` Baruch Siach
2015-03-10 19:28 ` [Buildroot] [PATCH v2 " Emeric Vigier
2015-03-10 23:41   ` Ryan Barnett
2015-03-11  5:06     ` Baruch Siach
2015-03-11  8:22       ` Angelo Compagnucci
2015-03-11  8:58         ` Baruch Siach
2015-03-12  8:32           ` Angelo Compagnucci
2015-03-12 14:56             ` Emeric Vigier [this message]
2015-03-12 14:44     ` Emeric Vigier
2015-03-12 14:46       ` Ryan Barnett
2015-03-12  8:36   ` Angelo Compagnucci
2015-03-12 15:59   ` Jérôme Oufella
2015-04-27  0:45 ` [Buildroot] [PATCH v3 " Emeric Vigier
2015-04-27  4:11   ` Baruch Siach
2015-04-28 14:36     ` Emeric Vigier
2015-04-27  8:28   ` Andreas Naumann
2015-04-28 15:06     ` Emeric Vigier
2015-07-14 21:56     ` Emeric Vigier
2015-07-16 15:15       ` Emeric Vigier
2015-07-23 20:51         ` Andreas Naumann
2015-10-04 16:56   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5501A90F.5040505@savoirfairelinux.com \
    --to=emeric.vigier@savoirfairelinux.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.