Re: [PATCH] VHD: Fix locale aware character encoding handling

[Philipp Hahn <hahn@univention.de>]

Hello Ian,

On 11.03.2015 13:30, Ian Campbell wrote:
> On Sun, 2015-03-08 at 11:54 +0100, Philipp Hahn wrote:
>> ASCII is 7 bit only, which does not work in UTF-8 environments:
>>> failed to read parent name
...
>> Don't check outbytesleft==0 as one UTF-8 characters get encoded into
>> 1..8 bytes, so it's perfectly fine (and expected) for the output to have
>> remaining bytes left.

...
> I'm a bit perplexed over why libvhd is even trying to interpret these
> bytes, I probably don't want to know...

If with bytes you mean the encoding used for the file-name: When
creating a snapshot the names are stored UTF-16 encoded for Windows  and
in UTF-8 for MacOS-X compatibility. Therefore the utility needs to know
from which encoding to start.

If with bytes you mean the (input|output)-bytes left: yeah, gory UTF-8
details.

> Anyway: acked + applied, thanks.

Thanks. I hope it builds on BSD or wherever vhd-utils are also used.

Philipp