From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW8bF-00071j-Ac for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW8b9-0000sZ-DJ for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:16:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57740 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW8b9-0000sL-6N for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:16:47 -0400 Message-ID: <5501E61D.5030102@suse.de> Date: Thu, 12 Mar 2015 20:16:45 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1426178624-32638-1-git-send-email-afaerber@suse.de> <1426178624-32638-9-git-send-email-afaerber@suse.de> <5501D556.9070105@redhat.com> In-Reply-To: <5501D556.9070105@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 8/9] memory: Move owner-less MemoryRegions to /machine/unattached List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 12.03.2015 um 19:05 schrieb Paolo Bonzini: > On 12/03/2015 17:43, Andreas F=C3=A4rber wrote: >> This cleans up the official /machine namespace. In particular >> /machine/system and /machine/io as well as entries with non-sanitized >> node names. >=20 > Just a question: isn't it /machine/system[0] and /machine/io[0]? You're right. Still, now that these names are used in a global generic context, I think "system" is too generic - "/machine/system-memory" would be better than "/machine/system[0]". Other names I referred to above are "vga ioports remapped[0]", "bochs dispi interface[0]" and "qemu extended regs[0]", each containing spaces. I.e., those names were at the time chosen as textual descriptions and not as QOM path components. >> >> Cc: Paolo Bonzini >> Signed-off-by: Andreas F=C3=A4rber >> --- >> memory.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/memory.c b/memory.c >> index 20f6d9e..ee3f2a8 100644 >> --- a/memory.c >> +++ b/memory.c >> @@ -868,7 +868,7 @@ void memory_region_init(MemoryRegion *mr, >> uint64_t size) >> { >> if (!owner) { >> - owner =3D qdev_get_machine(); >> + owner =3D container_get(qdev_get_machine(), "/unattached"); >> } >> =20 >> object_initialize(mr, sizeof(*mr), TYPE_MEMORY_REGION); >> >=20 > Acked-by: Paolo Bonzini Do you have any outstanding memory patches, or should I fix up the commit message and take it through qom-next? Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)