From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-x243.google.com (mail-pl0-x243.google.com [IPv6:2607:f8b0:400e:c01::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42BE96E041 for ; Sat, 18 Aug 2018 00:02:33 +0000 (UTC) Received: by mail-pl0-x243.google.com with SMTP id w14-v6so4384333plp.6 for ; Fri, 17 Aug 2018 17:02:33 -0700 (PDT) From: Dhinakaran Pandiyan Date: Fri, 17 Aug 2018 17:02:28 -0700 Message-ID: <5502300.ai65jdO5rW@dk> In-Reply-To: <20180817085642.19501-1-maarten.lankhorst@linux.intel.com> References: <20180817085642.19501-1-maarten.lankhorst@linux.intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 1/4] lib/psr: Add support for toggling edp psr through debugfs, v5. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst Cc: igt-dev@lists.freedesktop.org List-ID: T24gRnJpZGF5LCBBdWd1c3QgMTcsIDIwMTggMTo1NjozOSBBTSBQRFQgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gSXQncyBoYXJtZnVsIHRvIHdyaXRlIHRvIGVuYWJsZV9wc3IgYXQgcnVudGlt ZSwgYW5kIHRoZSBwYXRjaCB0aGF0IGFsbG93cwo+IHVzIHRvIGNoYW5nZSBpOTE1X2VkcF9wc3Jf ZGVidWcgd2l0aCB0aGUgcGFuZWwgcnVubmluZyB3aWxsIHJlcXVpcmUgdXMKPiB0byBhYmFuZG9u IHRoZSBtb2R1bGUgcGFyYW1ldGVyLiBIZW5jZSB0aGUgdXNlcnNwYWNlIGNoYW5nZSBuZWVkcyB0 byBiZQo+IHB1dCBpbiBJR1QgZmlyc3QgYmVmb3JlIHdlIGNhbiBjaGFuZ2UgaXQgYXQga2VybmVs IHRpbWUuCj4gCj4gVG9nZ2xpbmcgaXQgdG8gZGVidWdmcyB3aWxsIG1lYW4gd2UgY2FuIHNraXAg YSBtb2Rlc2V0IHdoZW4gY2hhbmdpbmcgb3VyCj4gZmVhdHVyZSBzZXQuCj4gCj4gQ2hhbmdlcyBz aW5jZSB2MToKPiAtIFJlYmFzZSB3aXRoIHRoZSBwcmV2aW91cyBwYXRjaGVzIGRyb3BwZWQuCj4g Q2hhbmdlcyBzaW5jZSB2MjoKPiAtIFJlYmFzZSBvbiB0b3Agb2YgbmV3IGFwaSBpbiBpOTE1X2Vk cF9wc3JfZGVidWcuCj4gQ2hhbmdlcyBzaW5jZSB2MzoKPiAtIEVuYWJsZSBJUlEgZGVidWdnaW5n IGZvciBleHRyYSBsb2dnaW5nLgo+IC0gRm9yY2UgUFNSMSBtb2RlLiAoZGhua3JuKQo+IC0gTW92 ZSBQU1IgZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb25zIHRvIGxpYi9pZ3RfcHNyLiAoZGhua3JuKQo+ IENoYW5nZXMgc2luY2UgdjQ6Cj4gLSBSZWRpc2FibGUgaXJxcyByaWdodCBhd2F5IHdoZW4gZGVi dWdmcyBhcGkgZG9lc24ndCB3b3JrLiAoZGhua3JuKQo+IC0gVXNlIGhleCBldmVyeXdoZXJlLiAo ZGhua3JuKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfcHNyLmMgICAgICAgICAg ICAgICAgICAgIHwgODYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgbGliL2ln dF9wc3IuaCAgICAgICAgICAgICAgICAgICAgfCAgMiArCj4gIHRlc3RzL2ttc19mcm9udGJ1ZmZl cl90cmFja2luZy5jIHwgIDYgKy0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgODkgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9wc3IuYyBiL2xpYi9p Z3RfcHNyLmMKPiBpbmRleCBjOTc5YjBiNTk5MzYuLjYxNGNhYTZmZDgwOSAxMDA2NDQKPiAtLS0g YS9saWIvaWd0X3Bzci5jCj4gKysrIGIvbGliL2lndF9wc3IuYwo+IEBAIC0yMSw3ICsyMSw5IEBA Cj4gICAqIElOIFRIRSBTT0ZUV0FSRS4KPiAgICovCj4gCj4gLSNpbmNsdWRlICAiaWd0X3Bzci5o Igo+ICsjaW5jbHVkZSAiaWd0X3Bzci5oIgo+ICsjaW5jbHVkZSAiaWd0X3N5c2ZzLmgiCj4gKyNp bmNsdWRlIDxlcnJuby5oPgo+IAo+ICBib29sIHBzcl9hY3RpdmUoaW50IGZkLCBib29sIGNoZWNr X2FjdGl2ZSkKPiAgewo+IEBAIC0zOCwzICs0MCw4NSBAQCBib29sIHBzcl93YWl0X2VudHJ5KGlu dCBmZCkKPiAgewo+ICAJcmV0dXJuIGlndF93YWl0KHBzcl9hY3RpdmUoZmQsIHRydWUpLCA1MDAs IDEpOwo+ICB9Cj4gKwo+ICtzdGF0aWMgc3NpemVfdCBwc3Jfd3JpdGUoaW50IGZkLCBjb25zdCBj aGFyICpidWYpCj4gK3sKPiArCXJldHVybiBpZ3Rfc3lzZnNfd3JpdGUoZmQsICJpOTE1X2VkcF9w c3JfZGVidWciLCBidWYsIHN0cmxlbihidWYpKTsKPiArfQo+ICsKPiArc3RhdGljIGludCBoYXNf cHNyX2RlYnVnZnMoaW50IGZkKQo+ICt7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCS8qCj4gKwkgKiBD aGVjayBpZiBuZXcgUFNSIGRlYnVnZnMgYXBpIGlzIHVzYWJsZSBieSB3cml0aW5nIGFuIGludmFs aWQgdmFsdWUuCj4gKwkgKiBMZWdhY3kgbW9kZSB3aWxsIHJldHVybiBPSyBoZXJlLCBkZWJ1Z2Zz IGFwaSB3aWxsIHJldHVybiAtRUlOVkFMLgo+ICsJICogLUVOT0RFViBpcyByZXR1cm5lZC4KCQle IHNvbWUgd29yZHMgYXJlIG1pc3NpbmcgaW4gdGhhdCBsYXN0IGxpbmUsIGNhbiB5b3UgZml4IHRo YXQgd2hlbiAKbWVyZ2luZz8KClBhdGNoZXMgMS0zIFJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBh bmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KCj4gKwkgKi8KPiArCXJldCA9 IHBzcl93cml0ZShmZCwgIjB4ZiIpOwo+ICsJaWYgKHJldCA9PSAtRUlOVkFMKQo+ICsJCXJldHVy biAwOwo+ICsJZWxzZSBpZiAocmV0IDwgMCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCS8qIGxl Z2FjeSBkZWJ1Z2ZzIGFwaSwgd2UgZW5hYmxlZCBpcnFzIGJ5IHdyaXRpbmcsIGRpc2FibGUgdGhl bS4gKi8KPiArCXBzcl93cml0ZShmZCwgIjAiKTsKPiArCXJldHVybiAtRUlOVkFMOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgYm9vbCBwc3JfbW9kcGFyYW1fc2V0KGludCB2YWwpCj4gK3sKPiArCXN0YXRp YyBpbnQgb2xkdmFsID0gLTE7Cj4gKwo+ICsJaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJlbmFi bGVfcHNyIiwgdmFsKTsKPiArCj4gKwlpZiAodmFsID09IG9sZHZhbCkKPiArCQlyZXR1cm4gZmFs c2U7Cj4gKwo+ICsJb2xkdmFsID0gdmFsOwo+ICsJcmV0dXJuIHRydWU7Cj4gK30KPiArCj4gK3N0 YXRpYyBpbnQgcHNyX3Jlc3RvcmVfZGVidWdmc19mZCA9IC0xOwo+ICsKPiArc3RhdGljIHZvaWQg cmVzdG9yZV9wc3JfZGVidWdmcyhpbnQgc2lnKQo+ICt7Cj4gKwlwc3Jfd3JpdGUocHNyX3Jlc3Rv cmVfZGVidWdmc19mZCwgIjAiKTsKPiArfQo+ICsKPiArc3RhdGljIGJvb2wgcHNyX3NldChpbnQg ZmQsIGJvb2wgZW5hYmxlKQo+ICt7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJldCA9IGhhc19wc3Jf ZGVidWdmcyhmZCk7Cj4gKwlpZiAocmV0ID09IC1FTk9ERVYpIHsKPiArCQlpZ3Rfc2tpcF9vbl9m KGVuYWJsZSwgIlBTUiBub3QgYXZhaWxhYmxlXG4iKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9 Cj4gKwo+ICsJaWYgKHJldCA9PSAtRUlOVkFMKSB7Cj4gKwkJcmV0ID0gcHNyX21vZHBhcmFtX3Nl dChlbmFibGUpOwo+ICsJfSBlbHNlIHsKPiArCQlyZXQgPSBwc3Jfd3JpdGUoZmQsIGVuYWJsZSA/ ICIweDMiIDogIjB4MSIpOwo+ICsJCWlndF9hc3NlcnQocmV0ID4gMCk7Cj4gKwl9Cj4gKwo+ICsJ LyogUmVzdG9yZSBvcmlnaW5hbCB2YWx1ZSBvbiBleGl0ICovCj4gKwlpZiAocHNyX3Jlc3RvcmVf ZGVidWdmc19mZCA9PSAtMSkgewo+ICsJCXBzcl9yZXN0b3JlX2RlYnVnZnNfZmQgPSBkdXAoZmQp Owo+ICsJCWlndF9hc3NlcnQocHNyX3Jlc3RvcmVfZGVidWdmc19mZCA+PSAwKTsKPiArCQlpZ3Rf aW5zdGFsbF9leGl0X2hhbmRsZXIocmVzdG9yZV9wc3JfZGVidWdmcyk7Cj4gKwl9Cj4gKwo+ICsJ cmV0dXJuIHJldDsKPiArfQo+ICsKPiArYm9vbCBwc3JfZW5hYmxlKGludCBmZCkKPiArewo+ICsJ cmV0dXJuIHBzcl9zZXQoZmQsIHRydWUpOwo+ICt9Cj4gKwo+ICtib29sIHBzcl9kaXNhYmxlKGlu dCBmZCkKPiArewo+ICsJcmV0dXJuIHBzcl9zZXQoZmQsIGZhbHNlKTsKPiArfQo+IGRpZmYgLS1n aXQgYS9saWIvaWd0X3Bzci5oIGIvbGliL2lndF9wc3IuaAo+IGluZGV4IDk4MGY4NWUwNGIzZS4u MGVmMjJjM2QxMjU4IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfcHNyLmgKPiArKysgYi9saWIvaWd0 X3Bzci5oCj4gQEAgLTMwLDUgKzMwLDcgQEAKPiAKPiAgYm9vbCBwc3Jfd2FpdF9lbnRyeShpbnQg ZmQpOwo+ICBib29sIHBzcl9hY3RpdmUoaW50IGZkLCBib29sIGNoZWNrX2FjdGl2ZSk7Cj4gK2Jv b2wgcHNyX2VuYWJsZShpbnQgZmQpOwo+ICtib29sIHBzcl9kaXNhYmxlKGludCBmZCk7Cj4gCj4g ICNlbmRpZgo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYwo+ IGIvdGVzdHMva21zX2Zyb250YnVmZmVyX3RyYWNraW5nLmMgaW5kZXggMWRmZDdjMWNlZThkLi43 ZWEyZjY5NzE4NGQgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX2Zyb250YnVmZmVyX3RyYWNraW5n LmMKPiArKysgYi90ZXN0cy9rbXNfZnJvbnRidWZmZXJfdHJhY2tpbmcuYwo+IEBAIC05NDEsOCAr OTQxLDYgQEAgc3RhdGljIGJvb2wgZHJyc193YWl0X3VudGlsX3JyX3N3aXRjaF90b19sb3codm9p ZCkKPiAKPiAgI2RlZmluZSBmYmNfZW5hYmxlKCkgaWd0X3NldF9tb2R1bGVfcGFyYW1faW50KCJl bmFibGVfZmJjIiwgMSkKPiAgI2RlZmluZSBmYmNfZGlzYWJsZSgpIGlndF9zZXRfbW9kdWxlX3Bh cmFtX2ludCgiZW5hYmxlX2ZiYyIsIDApCj4gLSNkZWZpbmUgcHNyX2VuYWJsZSgpIGlndF9zZXRf bW9kdWxlX3BhcmFtX2ludCgiZW5hYmxlX3BzciIsIDEpCj4gLSNkZWZpbmUgcHNyX2Rpc2FibGUo KSBpZ3Rfc2V0X21vZHVsZV9wYXJhbV9pbnQoImVuYWJsZV9wc3IiLCAwKQo+ICAjZGVmaW5lIGRy cnNfZW5hYmxlKCkJZHJyc19zZXQoMSkKPiAgI2RlZmluZSBkcnJzX2Rpc2FibGUoKQlkcnJzX3Nl dCgwKQo+IAo+IEBAIC0xMTM3LDcgKzExMzUsNyBAQCBzdGF0aWMgdm9pZCBkaXNhYmxlX2ZlYXR1 cmVzKGNvbnN0IHN0cnVjdCB0ZXN0X21vZGUKPiAqdCkgcmV0dXJuOwo+IAo+ICAJZmJjX2Rpc2Fi bGUoKTsKPiAtCXBzcl9kaXNhYmxlKCk7Cj4gKwlwc3JfZGlzYWJsZShkcm0uZGVidWdmcyk7Cj4g IAlkcnJzX2Rpc2FibGUoKTsKPiAgfQo+IAo+IEBAIC0xNzE5LDcgKzE3MTcsNyBAQCBzdGF0aWMg dm9pZCBlbmFibGVfZmVhdHVyZXNfZm9yX3Rlc3QoY29uc3Qgc3RydWN0Cj4gdGVzdF9tb2RlICp0 KSBpZiAodC0+ZmVhdHVyZSAmIEZFQVRVUkVfRkJDKQo+ICAJCWZiY19lbmFibGUoKTsKPiAgCWlm ICh0LT5mZWF0dXJlICYgRkVBVFVSRV9QU1IpCj4gLQkJcHNyX2VuYWJsZSgpOwo+ICsJCXBzcl9l bmFibGUoZHJtLmRlYnVnZnMpOwo+ICAJaWYgKHQtPmZlYXR1cmUgJiBGRUFUVVJFX0RSUlMpCj4g IAkJZHJyc19lbmFibGUoKTsKPiAgfQoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2Cg==