From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Subject: Re: [PATCH v10 6/7] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation Date: Fri, 13 Mar 2015 10:33:57 +0100 Message-ID: <5502AF05.9000504@linaro.org> References: <1423799232-10816-1-git-send-email-eric.auger@linaro.org> <1423799232-10816-7-git-send-email-eric.auger@linaro.org> <87bnkszs4u.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9BAFB48A0C for ; Fri, 13 Mar 2015 05:29:56 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cUDWYYdRuhlU for ; Fri, 13 Mar 2015 05:29:54 -0400 (EDT) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 71EC3489F7 for ; Fri, 13 Mar 2015 05:29:53 -0400 (EDT) Received: by wesx3 with SMTP id x3so22029444wes.4 for ; Fri, 13 Mar 2015 02:36:18 -0700 (PDT) In-Reply-To: <87bnkszs4u.fsf@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: eric.auger@st.com, patches@linaro.org, qemu-devel@nongnu.org, alex.williamson@redhat.com, pbonzini@redhat.com, feng.wu@intel.com, kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu QWxleCwKT24gMDIvMTcvMjAxNSAxMjozNiBQTSwgQWxleCBCZW5uw6llIHdyb3RlOgo+IAo+IEVy aWMgQXVnZXIgPGVyaWMuYXVnZXJAbGluYXJvLm9yZz4gd3JpdGVzOgo+IAo+PiB2ZmlvLWNhbHhl ZGEteGdtYWMgbm93IGNhbiBiZSBpbnN0YW50aWF0ZWQgdXNpbmcgdGhlIC1kZXZpY2Ugb3B0aW9u Lgo+PiBUaGUgbm9kZSBjcmVhdGlvbiBmdW5jdGlvbiBnZW5lcmF0ZXMgYSB2ZXJ5IGJhc2ljIGR0 IG5vZGUgY29tcG9zZWQKPj4gb2YgdGhlIGNvbXBhdCwgcmVnIGFuZCBpbnRlcnJ1cHRzIHByb3Bl cnRpZXMKPj4KPj4gU2lnbmVkLW9mZi1ieTogRXJpYyBBdWdlciA8ZXJpYy5hdWdlckBsaW5hcm8u b3JnPgo+Pgo+PiAtLS0KPj4gdjggLT4gdjk6Cj4+IC0gcHJvcGVybHkgZnJlZSByZXNvdXJjZXMg aW4gY2FzZSBvZiBlcnJvcnMgaW4KPj4gICBhZGRfY2FseGVkYV9taWR3YXlfeGdtYWNfZmR0X25v ZGUKPj4KPj4gdjcgLT4gdjg6Cj4+IC0gbW92ZSB0aGUgYWRkX2ZkdF9ub2RlX2Z1bmN0aW9ucyBh cnJheSBkZWNsYXJhdGlvbiBiZXR3ZWVuIHRoZSBkZXZpY2UKPj4gICBzcGVjaWZpYyBjb2RlIGFu ZCB0aGUgZ2VuZXJpYyBjb2RlIHRvIGF2b2lkIGZvcndhcmQgZGVjbGFyYXRpb25zIG9mCj4+ICAg ZGVjaWNlIHNwZWNpZmljIGZ1bmN0aW9ucwo+PiAtIHJlbmFtZSBhZGRfYmFzaWNfdmZpb19mZHRf bm9kZSBpbnRvCj4+ICAgYWRkX2NhbHhlZGFfbWlkd2F5X3hnbWFjX2ZkdF9ub2RlCj4+Cj4+IHY2 IC0+IHY3Ogo+PiAtIGNvbXBhdCBzdHJpbmcgcmUtZm9ybWF0dGluZyByZW1vdmVkIHNpbmNlIGNv bXBhdCBzdHJpbmcgaXMgbm90IGV4cG9zZWQKPj4gICBhbnltb3JlIGFzIGEgdXNlciBvcHRpb24K Pj4gLSBWRklPIElSUSBraWNrLW9mZiByZW1vdmVkIGZyb20gc3lzYnVzLWZkdCBhbmQgbW92ZWQg dG8gVkZJTyBwbGF0Zm9ybQo+PiAgIGRldmljZQo+PiAtLS0KPj4gIGh3L2FybS9zeXNidXMtZmR0 LmMgfCA4MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDgzIGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdp dCBhL2h3L2FybS9zeXNidXMtZmR0LmMgYi9ody9hcm0vc3lzYnVzLWZkdC5jCj4+IGluZGV4IDMw MzhiOTQuLmQ0Zjk3ZjUgMTAwNjQ0Cj4+IC0tLSBhL2h3L2FybS9zeXNidXMtZmR0LmMKPj4gKysr IGIvaHcvYXJtL3N5c2J1cy1mZHQuYwo+PiBAQCAtMjYsNiArMjYsOCBAQAo+PiAgI2luY2x1ZGUg InN5c2VtdS9kZXZpY2VfdHJlZS5oIgo+PiAgI2luY2x1ZGUgImh3L3BsYXRmb3JtLWJ1cy5oIgo+ PiAgI2luY2x1ZGUgInN5c2VtdS9zeXNlbXUuaCIKPj4gKyNpbmNsdWRlICJody92ZmlvL3ZmaW8t cGxhdGZvcm0uaCIKPj4gKyNpbmNsdWRlICJody92ZmlvL3ZmaW8tY2FseGVkYS14Z21hYy5oIgo+ PiAgCj4+ICAvKgo+PiAgICogaW50ZXJuYWwgc3RydWN0IHRoYXQgY29udGFpbnMgdGhlIGluZm9y bWF0aW9uIHRvIGNyZWF0ZSBkeW5hbWljCj4+IEBAIC01MywxMSArNTUsOTIgQEAgdHlwZWRlZiBz dHJ1Y3QgTm9kZUNyZWF0aW9uUGFpciB7Cj4+ICAgICAgaW50ICgqYWRkX2ZkdF9ub2RlX2ZuKShT eXNCdXNEZXZpY2UgKnNiZGV2LCB2b2lkICpvcGFxdWUpOwo+PiAgfSBOb2RlQ3JlYXRpb25QYWly Owo+PiAgCj4+ICsvKiBEZXZpY2UgU3BlY2lmaWMgQ29kZSAqLwo+PiArCj4+ICsvKioKPj4gKyAq IGFkZF9jYWx4ZWRhX21pZHdheV94Z21hY19mZHRfbm9kZQo+PiArICoKPj4gKyAqIEdlbmVyYXRl cyBhIHZlcnkgc2ltcGxlIG5vZGUgd2l0aCBmb2xsb3dpbmcgcHJvcGVydGllczoKPj4gKyAqIGNv bXBhdGlibGUgc3RyaW5nLCByZWdzLCBpbnRlcnJ1cHRzCj4+ICsgKi8KPj4gK3N0YXRpYyBpbnQg YWRkX2NhbHhlZGFfbWlkd2F5X3hnbWFjX2ZkdF9ub2RlKFN5c0J1c0RldmljZSAqc2JkZXYsIHZv aWQgKm9wYXF1ZSkKPj4gK3sKPj4gKyAgICBQbGF0Zm9ybUJ1c0ZEVERhdGEgKmRhdGEgPSBvcGFx dWU7Cj4+ICsgICAgUGxhdGZvcm1CdXNEZXZpY2UgKnBidXMgPSBkYXRhLT5wYnVzOwo+PiArICAg IHZvaWQgKmZkdCA9IGRhdGEtPmZkdDsKPj4gKyAgICBjb25zdCBjaGFyICpwYXJlbnRfbm9kZSA9 IGRhdGEtPnBidXNfbm9kZV9uYW1lOwo+PiArICAgIGludCBjb21wYXRfc3RyX2xlbjsKPj4gKyAg ICBjaGFyICpub2RlbmFtZTsKPj4gKyAgICBpbnQgaSwgcmV0ID0gLTE7Cj4+ICsgICAgdWludDMy X3QgKmlycV9hdHRyOwo+PiArICAgIHVpbnQ2NF90ICpyZWdfYXR0cjsKPj4gKyAgICB1aW50NjRf dCBtbWlvX2Jhc2U7Cj4+ICsgICAgdWludDY0X3QgaXJxX251bWJlcjsKPj4gKyAgICBWRklPUGxh dGZvcm1EZXZpY2UgKnZkZXYgPSBWRklPX1BMQVRGT1JNX0RFVklDRShzYmRldik7Cj4+ICsgICAg VkZJT0RldmljZSAqdmJhc2VkZXYgPSAmdmRldi0+dmJhc2VkZXY7Cj4+ICsgICAgT2JqZWN0ICpv YmogPSBPQkpFQ1Qoc2JkZXYpOwo+PiArCj4+ICsgICAgbW1pb19iYXNlID0gb2JqZWN0X3Byb3Bl cnR5X2dldF9pbnQob2JqLCAibW1pb1swXSIsIE5VTEwpOwo+PiArCj4+ICsgICAgbm9kZW5hbWUg PSBnX3N0cmR1cF9wcmludGYoIiVzLyVzQCUiIFBSSXg2NCwgcGFyZW50X25vZGUsCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdmJhc2VkZXYtPm5hbWUsCj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbW1pb19iYXNlKTsKPj4gKwo+PiArICAgIHFlbXVfZmR0X2Fk ZF9zdWJub2RlKGZkdCwgbm9kZW5hbWUpOwo+PiArCj4+ICsgICAgY29tcGF0X3N0cl9sZW4gPSBz dHJsZW4odmRldi0+Y29tcGF0KSArIDE7Cj4+ICsgICAgcWVtdV9mZHRfc2V0cHJvcChmZHQsIG5v ZGVuYW1lLCAiY29tcGF0aWJsZSIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHZkZXYt PmNvbXBhdCwgY29tcGF0X3N0cl9sZW4pOwo+PiArCj4+ICsgICAgcmVnX2F0dHIgPSBnX25ldyh1 aW50NjRfdCwgdmJhc2VkZXYtPm51bV9yZWdpb25zKjQpOwo+PiArCj4+ICsgICAgZm9yIChpID0g MDsgaSA8IHZiYXNlZGV2LT5udW1fcmVnaW9uczsgaSsrKSB7Cj4+ICsgICAgICAgIG1taW9fYmFz ZSA9IHBsYXRmb3JtX2J1c19nZXRfbW1pb19hZGRyKHBidXMsIHNiZGV2LCBpKTsKPj4gKyAgICAg ICAgcmVnX2F0dHJbNCppXSA9IDE7Cj4+ICsgICAgICAgIHJlZ19hdHRyWzQqaSsxXSA9IG1taW9f YmFzZTsKPj4gKyAgICAgICAgcmVnX2F0dHJbNCppKzJdID0gMTsKPj4gKyAgICAgICAgcmVnX2F0 dHJbNCppKzNdID0gbWVtb3J5X3JlZ2lvbl9zaXplKCZ2ZGV2LT5yZWdpb25zW2ldLT5tZW0pOwo+ PiArICAgIH0KPj4gKwo+PiArICAgIHJldCA9IHFlbXVfZmR0X3NldHByb3Bfc2l6ZWRfY2VsbHNf ZnJvbV9hcnJheShmZHQsIG5vZGVuYW1lLCAicmVnIiwKPj4gKyAgICAgICAgICAgICAgICAgICAg IHZiYXNlZGV2LT5udW1fcmVnaW9ucyoyLCByZWdfYXR0cik7Cj4gCj4gQ291bGQgd2UgdXNlIHFl bXVfZmR0X3NldHByb3Bfc2l6ZWRfY2VsbHMoKSBsaWtlIGV2ZXJ5b25lIGVsc2UgdG8gaGlkZQo+ IHRoZSB1Z2x5bmVzcyBvZiB0aGUgX2Zyb21fYXJyYXk/CgpEdWUgdG8gdGhlIGZhY3QgSSBuZWVk IHRvIGhhbmRsZSAnbnVtX3JlZ2lvbnMnIHJlZ2lvbnMsIEkgbmVlZCB0byBzZXR1cAp0aGUgYXJy YXkgcHJvZ3JhbW1hdGljYWxseS4gSSBjb3VsZCB1c2UgcWVtdV9mZHRfc2V0cHJvcCBpbnN0ZWFk IHNpbmNlCnRoZSBjZWxsIHNpemUgYWx3YXlzIGlzIDEgYnV0IEkgY3VycmVudGx5IGRvIG5vdCBz ZWUgaG93IEkgY291bGQgZWFzaWx5CnRha2UgYmVuZWZpdCBmcm9tIHFlbXVfZmR0X3NldHByb3Bf c2l6ZWRfY2VsbHMuCj4gCj4+ICsgICAgaWYgKHJldCkgewo+PiArICAgICAgICBlcnJvcl9yZXBv cnQoImNvdWxkIG5vdCBzZXQgcmVnIHByb3BlcnR5IG9mIG5vZGUgJXMiLCBub2RlbmFtZSk7Cj4+ ICsgICAgICAgIGdvdG8gZmFpbF9yZWc7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAgaXJxX2F0dHIg PSBnX25ldyh1aW50MzJfdCwgdmJhc2VkZXYtPm51bV9pcnFzKjMpOwo+PiArCj4+ICsgICAgZm9y IChpID0gMDsgaSA8IHZiYXNlZGV2LT5udW1faXJxczsgaSsrKSB7Cj4+ICsgICAgICAgIGlycV9u dW1iZXIgPSBwbGF0Zm9ybV9idXNfZ2V0X2lycW4ocGJ1cywgc2JkZXYgLCBpKQo+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICsgZGF0YS0+aXJxX3N0YXJ0Owo+PiArICAgICAgICBpcnFfYXR0 clszKmldID0gY3B1X3RvX2JlMzIoMCk7Cj4+ICsgICAgICAgIGlycV9hdHRyWzMqaSsxXSA9IGNw dV90b19iZTMyKGlycV9udW1iZXIpOwo+PiArICAgICAgICBpcnFfYXR0clszKmkrMl0gPSBjcHVf dG9fYmUzMigweDQpOwo+PiArICAgIH0KPj4gKwo+PiArICAgcmV0ID0gcWVtdV9mZHRfc2V0cHJv cChmZHQsIG5vZGVuYW1lLCAiaW50ZXJydXB0cyIsCj4+ICsgICAgICAgICAgICAgICAgICAgICBp cnFfYXR0ciwKPj4gdmJhc2VkZXYtPm51bV9pcnFzKjMqc2l6ZW9mKHVpbnQzMl90KSk7Cj4gCj4g RGl0dG8uCkhlcmUgYWxzbyBJIG5lZWQgdG8gaGFuZGxlIG51bV9pcnFzLiBCdXQgbWF5YmUgSSBt aXN1bmRlcnN0YW5kIHlvdXIKY29tbWVudCBoZXJlLgoKQmVzdCBSZWdhcmRzCgpFcmljCj4gCj4+ ICsgICAgaWYgKHJldCkgewo+PiArICAgICAgICBlcnJvcl9yZXBvcnQoImNvdWxkIG5vdCBzZXQg aW50ZXJydXB0cyBwcm9wZXJ0eSBvZiBub2RlICVzIiwKPj4gKyAgICAgICAgICAgICAgICAgICAg IG5vZGVuYW1lKTsKPj4gKyAgICB9Cj4+ICsKPj4gKyAgICBnX2ZyZWUoaXJxX2F0dHIpOwo+PiAr ZmFpbF9yZWc6Cj4+ICsgICAgZ19mcmVlKHJlZ19hdHRyKTsKPj4gKyAgICBnX2ZyZWUobm9kZW5h bWUpOwo+PiArICAgIHJldHVybiByZXQ7Cj4+ICt9Cj4+ICsKPj4gIC8qIGxpc3Qgb2Ygc3VwcG9y dGVkIGR5bmFtaWMgc3lzYnVzIGRldmljZXMgKi8KPj4gIHN0YXRpYyBjb25zdCBOb2RlQ3JlYXRp b25QYWlyIGFkZF9mZHRfbm9kZV9mdW5jdGlvbnNbXSA9IHsKPj4gKyAgICB7VFlQRV9WRklPX0NB TFhFREFfWEdNQUMsIGFkZF9jYWx4ZWRhX21pZHdheV94Z21hY19mZHRfbm9kZX0sCj4+ICAgICAg eyIiLCBOVUxMfSwgLyogbGFzdCBlbGVtZW50ICovCj4+ICB9Owo+PiAgCj4+ICsvKiBHZW5lcmlj IENvZGUgKi8KPj4gKwo+PiAgLyoqCj4+ICAgKiBhZGRfZmR0X25vZGUgLSBhZGQgdGhlIGRldmlj ZSB0cmVlIG5vZGUgb2YgYSBkeW5hbWljIHN5c2J1cyBkZXZpY2UKPj4gICAqCj4gCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBs aXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJp YS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWM10-0006OA-Jt for qemu-devel@nongnu.org; Fri, 13 Mar 2015 05:36:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWM0x-0005xj-Ay for qemu-devel@nongnu.org; Fri, 13 Mar 2015 05:36:22 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:32879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWM0x-0005xX-1y for qemu-devel@nongnu.org; Fri, 13 Mar 2015 05:36:19 -0400 Received: by widfb4 with SMTP id fb4so10528163wid.0 for ; Fri, 13 Mar 2015 02:36:18 -0700 (PDT) Message-ID: <5502AF05.9000504@linaro.org> Date: Fri, 13 Mar 2015 10:33:57 +0100 From: Eric Auger MIME-Version: 1.0 References: <1423799232-10816-1-git-send-email-eric.auger@linaro.org> <1423799232-10816-7-git-send-email-eric.auger@linaro.org> <87bnkszs4u.fsf@linaro.org> In-Reply-To: <87bnkszs4u.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v10 6/7] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: peter.maydell@linaro.org, eric.auger@st.com, patches@linaro.org, qemu-devel@nongnu.org, agraf@suse.de, alex.williamson@redhat.com, pbonzini@redhat.com, b.reynal@virtualopensystems.com, feng.wu@intel.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org Alex, On 02/17/2015 12:36 PM, Alex Bennée wrote: > > Eric Auger writes: > >> vfio-calxeda-xgmac now can be instantiated using the -device option. >> The node creation function generates a very basic dt node composed >> of the compat, reg and interrupts properties >> >> Signed-off-by: Eric Auger >> >> --- >> v8 -> v9: >> - properly free resources in case of errors in >> add_calxeda_midway_xgmac_fdt_node >> >> v7 -> v8: >> - move the add_fdt_node_functions array declaration between the device >> specific code and the generic code to avoid forward declarations of >> decice specific functions >> - rename add_basic_vfio_fdt_node into >> add_calxeda_midway_xgmac_fdt_node >> >> v6 -> v7: >> - compat string re-formatting removed since compat string is not exposed >> anymore as a user option >> - VFIO IRQ kick-off removed from sysbus-fdt and moved to VFIO platform >> device >> --- >> hw/arm/sysbus-fdt.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 83 insertions(+) >> >> diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c >> index 3038b94..d4f97f5 100644 >> --- a/hw/arm/sysbus-fdt.c >> +++ b/hw/arm/sysbus-fdt.c >> @@ -26,6 +26,8 @@ >> #include "sysemu/device_tree.h" >> #include "hw/platform-bus.h" >> #include "sysemu/sysemu.h" >> +#include "hw/vfio/vfio-platform.h" >> +#include "hw/vfio/vfio-calxeda-xgmac.h" >> >> /* >> * internal struct that contains the information to create dynamic >> @@ -53,11 +55,92 @@ typedef struct NodeCreationPair { >> int (*add_fdt_node_fn)(SysBusDevice *sbdev, void *opaque); >> } NodeCreationPair; >> >> +/* Device Specific Code */ >> + >> +/** >> + * add_calxeda_midway_xgmac_fdt_node >> + * >> + * Generates a very simple node with following properties: >> + * compatible string, regs, interrupts >> + */ >> +static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) >> +{ >> + PlatformBusFDTData *data = opaque; >> + PlatformBusDevice *pbus = data->pbus; >> + void *fdt = data->fdt; >> + const char *parent_node = data->pbus_node_name; >> + int compat_str_len; >> + char *nodename; >> + int i, ret = -1; >> + uint32_t *irq_attr; >> + uint64_t *reg_attr; >> + uint64_t mmio_base; >> + uint64_t irq_number; >> + VFIOPlatformDevice *vdev = VFIO_PLATFORM_DEVICE(sbdev); >> + VFIODevice *vbasedev = &vdev->vbasedev; >> + Object *obj = OBJECT(sbdev); >> + >> + mmio_base = object_property_get_int(obj, "mmio[0]", NULL); >> + >> + nodename = g_strdup_printf("%s/%s@%" PRIx64, parent_node, >> + vbasedev->name, >> + mmio_base); >> + >> + qemu_fdt_add_subnode(fdt, nodename); >> + >> + compat_str_len = strlen(vdev->compat) + 1; >> + qemu_fdt_setprop(fdt, nodename, "compatible", >> + vdev->compat, compat_str_len); >> + >> + reg_attr = g_new(uint64_t, vbasedev->num_regions*4); >> + >> + for (i = 0; i < vbasedev->num_regions; i++) { >> + mmio_base = platform_bus_get_mmio_addr(pbus, sbdev, i); >> + reg_attr[4*i] = 1; >> + reg_attr[4*i+1] = mmio_base; >> + reg_attr[4*i+2] = 1; >> + reg_attr[4*i+3] = memory_region_size(&vdev->regions[i]->mem); >> + } >> + >> + ret = qemu_fdt_setprop_sized_cells_from_array(fdt, nodename, "reg", >> + vbasedev->num_regions*2, reg_attr); > > Could we use qemu_fdt_setprop_sized_cells() like everyone else to hide > the uglyness of the _from_array? Due to the fact I need to handle 'num_regions' regions, I need to setup the array programmatically. I could use qemu_fdt_setprop instead since the cell size always is 1 but I currently do not see how I could easily take benefit from qemu_fdt_setprop_sized_cells. > >> + if (ret) { >> + error_report("could not set reg property of node %s", nodename); >> + goto fail_reg; >> + } >> + >> + irq_attr = g_new(uint32_t, vbasedev->num_irqs*3); >> + >> + for (i = 0; i < vbasedev->num_irqs; i++) { >> + irq_number = platform_bus_get_irqn(pbus, sbdev , i) >> + + data->irq_start; >> + irq_attr[3*i] = cpu_to_be32(0); >> + irq_attr[3*i+1] = cpu_to_be32(irq_number); >> + irq_attr[3*i+2] = cpu_to_be32(0x4); >> + } >> + >> + ret = qemu_fdt_setprop(fdt, nodename, "interrupts", >> + irq_attr, >> vbasedev->num_irqs*3*sizeof(uint32_t)); > > Ditto. Here also I need to handle num_irqs. But maybe I misunderstand your comment here. Best Regards Eric > >> + if (ret) { >> + error_report("could not set interrupts property of node %s", >> + nodename); >> + } >> + >> + g_free(irq_attr); >> +fail_reg: >> + g_free(reg_attr); >> + g_free(nodename); >> + return ret; >> +} >> + >> /* list of supported dynamic sysbus devices */ >> static const NodeCreationPair add_fdt_node_functions[] = { >> + {TYPE_VFIO_CALXEDA_XGMAC, add_calxeda_midway_xgmac_fdt_node}, >> {"", NULL}, /* last element */ >> }; >> >> +/* Generic Code */ >> + >> /** >> * add_fdt_node - add the device tree node of a dynamic sysbus device >> * >