From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 3/3] KVM: For the symbols used locally only should be static type. Date: Fri, 13 Mar 2015 14:37:29 +0100 Message-ID: <5502E819.7010609@de.ibm.com> References: <1426239586-1369-1-git-send-email-lixiubo@cmss.chinamobile.com> <1426239586-1369-4-git-send-email-lixiubo@cmss.chinamobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org To: Xiubo Li , mtosatti@redhat.com Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:58957 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbCMNhj (ORCPT ); Fri, 13 Mar 2015 09:37:39 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Mar 2015 13:37:37 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8F65C219004D for ; Fri, 13 Mar 2015 13:37:23 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2DDbWk23014992 for ; Fri, 13 Mar 2015 13:37:32 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2DDbUDT019159 for ; Fri, 13 Mar 2015 07:37:32 -0600 In-Reply-To: <1426239586-1369-4-git-send-email-lixiubo@cmss.chinamobile.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 13.03.2015 um 10:39 schrieb Xiubo Li: > This patch fix the following sparse warnings: > > for file virt/kvm/kvm_main.c: > warning: symbol 'halt_poll_ns' was not declared. Should it be static? > > Signed-off-by: Xiubo Li > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index a109370..a23d2ba 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -66,7 +66,7 @@ > MODULE_AUTHOR("Qumranet"); > MODULE_LICENSE("GPL"); > > -unsigned int halt_poll_ns = 0; > +static unsigned int halt_poll_ns; > module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR); > > /* > This change is already part of kvm/queue https://git.kernel.org/cgit/virt/kvm/kvm.git/commit/?h=queue&id=0fa9778895635ab3824caf34fd573562dd2b999c