From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932441AbbCMPb1 (ORCPT ); Fri, 13 Mar 2015 11:31:27 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44503 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030210AbbCMPbX (ORCPT ); Fri, 13 Mar 2015 11:31:23 -0400 Message-ID: <550302C5.9050809@ti.com> Date: Fri, 13 Mar 2015 21:01:17 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Nishanth Menon , , , CC: , Subject: Re: [PATCH 1/2] ARM: dts: am4372: Add "ti,am437x-ocp2scp" as compatible string for OCP2SCP References: <1426259580-10043-1-git-send-email-kishon@ti.com> <5502FF0E.7090502@ti.com> In-Reply-To: <5502FF0E.7090502@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday 13 March 2015 08:45 PM, Nishanth Menon wrote: > On 03/13/2015 10:12 AM, Kishon Vijay Abraham I wrote: >> Added a new compatible string "ti,am437x-ocp2scp" for OCP2SCP module. >> This is needed since except for the OCP2SCP used in AM437x, SYNC2 value >> in OCP2SCP TIMING should be changed whereas the default value is sufficient >> in AM437x. >> >> Cc: Tony Lindgren >> Signed-off-by: Kishon Vijay Abraham I >> --- >> .../devicetree/bindings/bus/omap-ocp2scp.txt | 3 ++- >> arch/arm/boot/dts/am4372.dtsi | 4 ++-- >> 2 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt >> index 63dd805..18729f6 100644 >> --- a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt >> +++ b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt >> @@ -1,7 +1,8 @@ >> * OMAP OCP2SCP - ocp interface to scp interface >> >> properties: >> -- compatible : Should be "ti,omap-ocp2scp" >> +- compatible : Should be "ti,am437x-ocp2scp" for AM437x processor >> + Should be "ti,omap-ocp2scp" for all others >> - reg : Address and length of the register set for the device >> - #address-cells, #size-cells : Must be present if the device has sub-nodes >> - ranges : the child address space are mapped 1:1 onto the parent address space >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index 1943fc3..286e317 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -787,7 +787,7 @@ >> }; >> >> ocp2scp0: ocp2scp@483a8000 { >> - compatible = "ti,omap-ocp2scp"; >> + compatible = "ti,am437x-ocp2scp", "ti,omap-ocp2scp"; >> #address-cells = <1>; >> #size-cells = <1>; >> ranges; >> @@ -806,7 +806,7 @@ >> }; >> >> ocp2scp1: ocp2scp@483e8000 { >> - compatible = "ti,omap-ocp2scp"; >> + compatible = "ti,am437x-ocp2scp", "ti,omap-ocp2scp"; >> #address-cells = <1>; >> #size-cells = <1>; >> ranges; >> > > > is there a reason you chose not to --cc > 'linux-arm-kernel@lists.infradead.org' --cc > 'linux-kernel@vger.kernel.org' --cc 'linux-doc@vger.kernel.org' --cc > 'devicetree@vger.kernel.org' --cc linux-omap@vger.kernel.org ? no, my bad. > > > please repost with a proper cover-letter to all appropriate lists. sure will resend. I don't think cover-letter is necessary here since it will just have the same info of the commit log. Thanks Kishon