Re: [PATCH] add upstream GRUB to the Xen build system

[David Vrabel <david.vrabel@citrix.com>]

On 13/03/15 16:02, Stefano Stabellini wrote:
> On Fri, 13 Mar 2015, David Vrabel wrote:
>> On 13/03/15 15:33, Stefano Stabellini wrote:
>>> Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2
>>> binaries. See Ian's blog post for more information:
>>
>> Why?  If pvgrub2 is available on the system libxl should make use of it,
>> but there doesn't seem to be a good reason for cloning and building yet
>> another third-party project as part of the Xen build.
>>
>> At a minimum this needs a configure option to disable it.
> 
> It is the only way to boot grub2 pv guests securely.  More importantly
> it is also the first step toward adding an osstest test for upstream
> grub.

osstest can clone and build grub if necessary, it doesn't need to be
part of the Xen build.

> Finally it will allow us to get rid of pvgrub1 in the future. As a
> matter of fact I already have a patch to remove pvgrub, if the
> maintainers feel that it is already the time I am happy to send it out.

The majority of projects would handle this by listing grub 2.x as a
requirement in the release notes or similar.

David