From: Andrew Cooper <andrew.cooper3@citrix.com>
To: xen-devel@lists.xen.org
Subject: Re: [PATCH 2/4] x86/MSI-X: access MSI‑X table only after having enabled MSI‑X
Date: Fri, 13 Mar 2015 19:18:05 +0000 [thread overview]
Message-ID: <550337ED.10705@citrix.com> (raw)
In-Reply-To: <54FF29C20200007800068359@mail.emea.novell.com>
On 10/03/15 16:28, Jan Beulich wrote:
> As done in Linux by f598282f51 ("PCI: Fix the NIU MSI-X problem in a
> better way") and its broken predecessor, make sure we don't access the
> MSI-X table without having enabled MSI-X first, using the mask-all flag
> instead to prevent interrupts from occurring.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
General quarms of this series aside, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>
There is a spurious whitespace change and a spurious comment change
which you perhaps didn't mean to include.
next prev parent reply other threads:[~2015-03-13 19:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 16:16 [PATCH 0/4] x86/MSI-X: XSA-120 follow-up Jan Beulich
2015-03-10 16:27 ` [PATCH 1/4] x86/MSI-X: be more careful during teardown Jan Beulich
2015-03-10 21:05 ` Andrew Cooper
2015-03-11 8:22 ` Jan Beulich
2015-03-13 18:10 ` Andrew Cooper
2015-03-16 11:03 ` Jan Beulich
2015-03-10 16:28 ` [PATCH 2/4] x86/MSI-X: access MSI‑X table only after having enabled MSI‑X Jan Beulich
2015-03-13 19:18 ` Andrew Cooper [this message]
2015-03-16 11:13 ` Jan Beulich
2015-03-10 16:29 ` [PATCH 3/4] x86/MSI-X: reduce fiddling with control register during restore Jan Beulich
2015-03-13 19:38 ` Andrew Cooper
2015-03-10 16:29 ` [PATCH 4/4] x86/MSI-X: cleanup Jan Beulich
2015-03-13 19:56 ` Andrew Cooper
2015-03-13 20:16 ` [PATCH 0/4] x86/MSI-X: XSA-120 follow-up Andrew Cooper
2015-03-16 15:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550337ED.10705@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.