From: Eric Sandeen <sandeen@redhat.com>
To: Brian Foster <bfoster@redhat.com>, Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/4] xfs_repair: validate & fix inode CRCs
Date: Fri, 13 Mar 2015 17:42:42 -0500 [thread overview]
Message-ID: <550367E2.70605@redhat.com> (raw)
In-Reply-To: <20150313132006.GA2678@laptop.bfoster>
On 3/13/15 8:20 AM, Brian Foster wrote:
...
> What about verify_mode? It should probably report the inode as bunk if
> the crc is bad. Some of the subsequent checks handle this with some
> logic to just return 1 if something is bogus and we're in verify mode.
So, I read through the verify_mode portion on the plane ride back; I think
it's gotten a bit inconsistent over time. I feel like I understand it a
bit better now, and will send a v3 which matches what I understand to be
its intent, and another patch to document it & make the rest consistent.
Thanks for keeping me honest. ;)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-03-13 22:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 20:56 [PATCH 0/4] xfsprogs: a handful of fixes Eric Sandeen
2015-03-04 20:58 ` [PATCH 1/4] xfs_repair: validate & fix inode CRCs Eric Sandeen
2015-03-09 18:41 ` Carlos Maiolino
2015-03-13 13:20 ` Brian Foster
2015-03-13 22:42 ` Eric Sandeen [this message]
2015-03-04 20:59 ` [PATCH 2/4] xfs_repair: clear need_root_dotdot if we rebuild the root dir Eric Sandeen
2015-03-09 18:43 ` Carlos Maiolino
2015-03-04 21:00 ` [PATCH 3/4] xfs_db: show nlink fields for di_version == 3, too Eric Sandeen
2015-03-09 18:49 ` Carlos Maiolino
2015-03-09 20:41 ` Eric Sandeen
2015-03-13 13:20 ` Brian Foster
2015-03-04 21:02 ` [PATCH 4/4] xfs_repair: set *parent if process_dir2_data() fixes root inode's parent Eric Sandeen
2015-03-09 18:50 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550367E2.70605@redhat.com \
--to=sandeen@redhat.com \
--cc=bfoster@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.