From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/7] pkg-generic: take into account <pkg>_EXTRA_DOWNLOADS to display "Downloading" message
Date: Sun, 15 Mar 2015 17:44:41 +0100 [thread overview]
Message-ID: <5505B6F9.3000402@openwide.fr> (raw)
In-Reply-To: <1425147313-17380-4-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas,
Le 28/02/2015 19:15, Thomas Petazzoni a ?crit :
> The .stamp_downloaded target displays the "Downloading" message even
> if there is really something to download. However, this logic only
> checks for <pkg>_SOURCE and <pkg>_PATCH: it does not check if
> something needs to be downloaded in <pkg>_EXTRA_DOWNLOADS.
>
> This commit fixes that, which makes sure that the "Downloading"
> message is displayed if one of the items in <pkg>_EXTRA_DOWNLOADS has
> not yet been downloaded.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
Reviewed-by: Romain Naour <romain.naour@openwide.fr>
> package/pkg-generic.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 1482194..0098b29 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -76,7 +76,7 @@ ifeq ($(DL_MODE),DOWNLOAD)
> $(Q)if test ! -e $(DL_DIR)/$($(PKG)_SOURCE); then \
> $(call MESSAGE,"Downloading") ; \
> else \
> - for p in $($(PKG)_PATCH) ; do \
> + for p in $($(PKG)_PATCH) $($(PKG)_EXTRA_DOWNLOADS) ; do \
> if test ! -e $(DL_DIR)/`basename $$p` ; then \
> $(call MESSAGE,"Downloading") ; \
> break ; \
>
next prev parent reply other threads:[~2015-03-15 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 18:15 [Buildroot] [PATCH 0/7] Improvements to the download logic Thomas Petazzoni
2015-02-28 18:15 ` [Buildroot] [PATCH 1/7] linux: use the package infrastructure to download patches Thomas Petazzoni
2015-02-28 19:54 ` Baruch Siach
2015-03-15 14:59 ` Romain Naour
2015-03-15 15:14 ` Thomas Petazzoni
2015-03-15 15:58 ` Romain Naour
2015-03-22 15:15 ` Arnout Vandecappelle
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:16 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 2/7] pkg-generic: fix the logic showing the "Downloading" message Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:19 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 3/7] pkg-generic: take into account <pkg>_EXTRA_DOWNLOADS to display " Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour [this message]
2015-03-22 15:20 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 4/7] pkg-generic: refactor the "Downloading" message logic Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:29 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 5/7] pkg-generic: allow full URLs for <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:45 ` Romain Naour
2015-03-22 15:33 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 6/7] docs/manual: update documentation about <pkg>_SOURCE, <pkg>_PATCH and <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:45 ` Romain Naour
2015-03-22 15:58 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 7/7] perl: use <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:46 ` Romain Naour
2015-03-22 15:59 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5505B6F9.3000402@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.