From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:34118 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933226AbcK2SBt (ORCPT ); Tue, 29 Nov 2016 13:01:49 -0500 From: Laurent Pinchart To: Daniel Vetter Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, Alison Wang , Jingoo Han , Seung-Woo Kim , Xinwei Kong , linux-renesas-soc@vger.kernel.org, Kyungmin Park , Xinliang Liu , Chen Feng , Rongrong Zou , Maxime Ripard , Vincent Abriou Subject: Re: [PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code Date: Tue, 29 Nov 2016 20:02:01 +0200 Message-ID: <5506403.Ty4tXHheMg@avalon> In-Reply-To: <20161129100527.d2tbv7vk75zqgkax@phenom.ffwll.local> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <6045676.cxyeoxsW2K@avalon> <20161129100527.d2tbv7vk75zqgkax@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Daniel, On Tuesday 29 Nov 2016 11:05:27 Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 11:43:19AM +0200, Laurent Pinchart wrote: > > On Tuesday 29 Nov 2016 10:35:24 Daniel Vetter wrote: > >> On Tue, Nov 29, 2016 at 11:04:33AM +0200, Laurent Pinchart wrote: > >>> Instead of linking encoders and bridges in every driver (and getting > >>> it wrong half of the time, as many drivers forget to set the > >>> drm_bridge encoder pointer), do so in core code. The > >>> drm_bridge_attach() function needs the encoder and optional previous > >>> bridge to perform that task, update all the callers. > >>> > >>> Signed-off-by: Laurent Pinchart > >>> > >>> --- > >>> > >>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 4 +- > >>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +- > >>> drivers/gpu/drm/bridge/dw-hdmi.c | 3 +- > >>> drivers/gpu/drm/drm_bridge.c | 46 +++++++++---- > >>> drivers/gpu/drm/drm_simple_kms_helper.c | 4 +- > >>> drivers/gpu/drm/exynos/exynos_dp.c | 5 +-- > >>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 6 +-- > >>> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 5 +-- > >>> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 +-- > >>> drivers/gpu/drm/imx/imx-ldb.c | 6 +-- > >>> drivers/gpu/drm/imx/parallel-display.c | 4 +- > >>> drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++-- > >>> drivers/gpu/drm/mediatek/mtk_dsi.c | 24 ++--------- > >>> drivers/gpu/drm/mediatek/mtk_hdmi.c | 11 +++--- > >>> drivers/gpu/drm/msm/dsi/dsi_manager.c | 17 +++++--- > >>> drivers/gpu/drm/msm/edp/edp_bridge.c | 2 +- > >>> drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- > >>> drivers/gpu/drm/rcar-du/rcar_du_hdmienc.c | 5 +-- > >>> drivers/gpu/drm/sti/sti_dvo.c | 3 +- > >>> drivers/gpu/drm/sti/sti_hda.c | 3 +- > >>> drivers/gpu/drm/sti/sti_hdmi.c | 3 +- > >>> drivers/gpu/drm/sun4i/sun4i_rgb.c | 13 +++--- > >>> include/drm/drm_bridge.h | 3 +- > >>> 23 files changed, 83 insertions(+), 103 deletions(-) > > > > [snip] > > > >>> diff --git a/drivers/gpu/drm/drm_bridge.c > >>> b/drivers/gpu/drm/drm_bridge.c > >>> index 0ee052b7c21a..850bd6509ef1 100644 > >>> --- a/drivers/gpu/drm/drm_bridge.c > >>> +++ b/drivers/gpu/drm/drm_bridge.c [snip] > >>> -int drm_bridge_attach(struct drm_device *dev, struct drm_bridge > >>> *bridge) > >>> +int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge > >>> *bridge, > >>> + struct drm_bridge *previous) > >>> { > >>> - if (!dev || !bridge) > >>> + int ret; > >>> + > >>> + if (!encoder || !bridge) > >>> + return -EINVAL; > >>> + > >>> + if (previous && (!previous->dev || previous->encoder != encoder)) > >>> return -EINVAL; > >> > >> Not sure we want to allow setting both encoder and bridge for chaining. > >> I'd kinda expect that for chained use-case the bridge doesn't care that > >> much who started the chain. And if not we can always create a helper to > >> look up the drm_encoder. > > > > As bridge drivers currently create connectors (I'd like to change that at > > some point, but one thing at a time) they need to call > > drm_mode_connector_attach_encoder() and thus need to have access to the > > drm_encoder object at the beginning of the chain. The drm_bridge structure > > has an encoder field, it seems to me that the easiest is to always > > populate it, regardless of the position of the bridge in the chain. > > I mean the function inteface, not what we fill out in the drm_bridge > struct. I.e. instead of expecting callers to give you the encoder for > chained bridges, look it up yourself: > > bridge->encoder = previous : previous->encoder ? encoder; > > Or something like that. Just feels confusing to connect a bridge to both > a bridge _and_ the first encoder. Right. Archit proposed doing it the other way around: previous = encoder->bridge; while (previous && previous->next) previous = previous->next; That would simplify the API, at the cost of preventing us from catching drivers that attach bridges in the wrong order (through the !previous->dev check that you suggested should be turned into a WARN_ON). The previous- >encoder != encoder check is also a safety net. Any opinion on which option you like better ? I'd be very tempted to go for Archit's proposal as it removes the previous parameter from the API, if it wasn't for the loss of sanity checking. > Wrt creating the connector: Some helpers to make that easier could be > useful, and probably we need a separate ->register callback. That's needed > for proper demidlayered init/teardown sequence anyway, and then the > drm_bridge.c code make sure to only call ->register for the very last > bridge. Other bridges could still create ther connectors (less conditions > in the code), as long as they don't register them no one will ever see > them ;-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code Date: Tue, 29 Nov 2016 20:02:01 +0200 Message-ID: <5506403.Ty4tXHheMg@avalon> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <6045676.cxyeoxsW2K@avalon> <20161129100527.d2tbv7vk75zqgkax@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF0DE89D77 for ; Tue, 29 Nov 2016 18:01:47 +0000 (UTC) In-Reply-To: <20161129100527.d2tbv7vk75zqgkax@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Xinliang Liu , Laurent Pinchart , Alison Wang , Jingoo Han , Seung-Woo Kim , Kyungmin Park , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Xinwei Kong , Chen Feng , Rongrong Zou , Maxime Ripard , Vincent Abriou List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gVHVlc2RheSAyOSBOb3YgMjAxNiAxMTowNToyNyBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+IE9uIFR1ZSwgTm92IDI5LCAyMDE2IGF0IDExOjQzOjE5QU0gKzAyMDAsIExhdXJl bnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBUdWVzZGF5IDI5IE5vdiAyMDE2IDEwOjM1OjI0IERh bmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4gT24gVHVlLCBOb3YgMjksIDIwMTYgYXQgMTE6MDQ6MzNB TSArMDIwMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4gSW5zdGVhZCBvZiBsaW5raW5n IGVuY29kZXJzIGFuZCBicmlkZ2VzIGluIGV2ZXJ5IGRyaXZlciAoYW5kIGdldHRpbmcKPiA+Pj4g aXQgd3JvbmcgaGFsZiBvZiB0aGUgdGltZSwgYXMgbWFueSBkcml2ZXJzIGZvcmdldCB0byBzZXQg dGhlCj4gPj4+IGRybV9icmlkZ2UgZW5jb2RlciBwb2ludGVyKSwgZG8gc28gaW4gY29yZSBjb2Rl LiBUaGUKPiA+Pj4gZHJtX2JyaWRnZV9hdHRhY2goKSBmdW5jdGlvbiBuZWVkcyB0aGUgZW5jb2Rl ciBhbmQgb3B0aW9uYWwgcHJldmlvdXMKPiA+Pj4gYnJpZGdlIHRvIHBlcmZvcm0gdGhhdCB0YXNr LCB1cGRhdGUgYWxsIHRoZSBjYWxsZXJzLgo+ID4+PiAKPiA+Pj4gU2lnbmVkLW9mZi1ieTogTGF1 cmVudCBQaW5jaGFydAo+ID4+PiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2Fy ZC5jb20+Cj4gPj4+IC0tLQo+ID4+PiAKPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9hdG1lbC1obGNk Yy9hdG1lbF9obGNkY19vdXRwdXQuYyAgIHwgIDQgKy0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jIHwgIDQgKy0KPiA+Pj4gIGRyaXZlcnMv Z3B1L2RybS9icmlkZ2UvZHctaGRtaS5jICAgICAgICAgICAgICAgICAgIHwgIDMgKy0KPiA+Pj4g IGRyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMgICAgICAgICAgICAgICAgICAgICAgIHwgNDYg KysrKysrKysrLS0tLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBl ci5jICAgICAgICAgICAgfCAgNCArLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlu b3NfZHAuYyAgICAgICAgICAgICAgICAgfCAgNSArLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9l eHlub3MvZXh5bm9zX2RybV9kc2kuYyAgICAgICAgICAgIHwgIDYgKy0tCj4gPj4+ICBkcml2ZXJz L2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9yZ2IuYyAgICAgICAgICB8ICA1ICstLQo+ID4+ PiAgZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9kd19kcm1fZHNpLmMgICAgICAgfCAg NSArLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWxkYi5jICAgICAgICAgICAgICAg ICAgICAgIHwgIDYgKy0tCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0vaW14L3BhcmFsbGVsLWRpc3Bs YXkuYyAgICAgICAgICAgICB8ICA0ICstCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RwaS5jICAgICAgICAgICAgICAgICB8ICA4ICsrLS0KPiA+Pj4gIGRyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHNpLmMgICAgICAgICAgICAgICAgIHwgMjQgKystLS0tLS0tLS0KPiA+ Pj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jICAgICAgICAgICAgICAgIHwg MTEgKysrLS0tCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfbWFuYWdlci5jICAg ICAgICAgICAgICB8IDE3ICsrKysrLS0tCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2VkcC9l ZHBfYnJpZGdlLmMgICAgICAgICAgICAgICB8ICAyICstCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0v bXNtL2hkbWkvaGRtaV9icmlkZ2UuYyAgICAgICAgICAgICB8ICAyICstCj4gPj4+ICBkcml2ZXJz L2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2hkbWllbmMuYyAgICAgICAgICB8ICA1ICstLQo+ID4+ PiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZHZvLmMgICAgICAgICAgICAgICAgICAgICAgfCAg MyArLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRhLmMgICAgICAgICAgICAgICAg ICAgICAgfCAgMyArLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRtaS5jICAgICAg ICAgICAgICAgICAgICAgfCAgMyArLQo+ID4+PiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X3JnYi5jICAgICAgICAgICAgICAgICAgfCAxMyArKystLS0KPiA+Pj4gIGluY2x1ZGUvZHJtL2Ry bV9icmlkZ2UuaCAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDMgKy0KPiA+Pj4gIDIzIGZp bGVzIGNoYW5nZWQsIDgzIGluc2VydGlvbnMoKyksIDEwMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4g W3NuaXBdCj4gPiAKPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdl LmMKPiA+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2JyaWRnZS5jCj4gPj4+IGluZGV4IDBlZTA1 MmI3YzIxYS4uODUwYmQ2NTA5ZWYxIDEwMDY0NAo+ID4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2JyaWRnZS5jCj4gPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMKCltz bmlwXQoKPiA+Pj4gLWludCBkcm1fYnJpZGdlX2F0dGFjaChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCBzdHJ1Y3QgZHJtX2JyaWRnZQo+ID4+PiAqYnJpZGdlKQo+ID4+PiAraW50IGRybV9icmlkZ2Vf YXR0YWNoKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rlciwgc3RydWN0IGRybV9icmlkZ2UKPiA+ Pj4gKmJyaWRnZSwKPiA+Pj4gKwkJICAgICAgc3RydWN0IGRybV9icmlkZ2UgKnByZXZpb3VzKQo+ ID4+PiAgewo+ID4+PiAtCWlmICghZGV2IHx8ICFicmlkZ2UpCj4gPj4+ICsJaW50IHJldDsKPiA+ Pj4gKwo+ID4+PiArCWlmICghZW5jb2RlciB8fCAhYnJpZGdlKQo+ID4+PiArCQlyZXR1cm4gLUVJ TlZBTDsKPiA+Pj4gKwo+ID4+PiArCWlmIChwcmV2aW91cyAmJiAoIXByZXZpb3VzLT5kZXYgfHwg cHJldmlvdXMtPmVuY29kZXIgIT0gZW5jb2RlcikpCj4gPj4+ICAJCXJldHVybiAtRUlOVkFMOwo+ ID4+IAo+ID4+IE5vdCBzdXJlIHdlIHdhbnQgdG8gYWxsb3cgc2V0dGluZyBib3RoIGVuY29kZXIg YW5kIGJyaWRnZSBmb3IgY2hhaW5pbmcuCj4gPj4gSSdkIGtpbmRhIGV4cGVjdCB0aGF0IGZvciBj aGFpbmVkIHVzZS1jYXNlIHRoZSBicmlkZ2UgZG9lc24ndCBjYXJlIHRoYXQKPiA+PiBtdWNoIHdo byBzdGFydGVkIHRoZSBjaGFpbi4gQW5kIGlmIG5vdCB3ZSBjYW4gYWx3YXlzIGNyZWF0ZSBhIGhl bHBlciB0bwo+ID4+IGxvb2sgdXAgdGhlIGRybV9lbmNvZGVyLgo+ID4gCj4gPiBBcyBicmlkZ2Ug ZHJpdmVycyBjdXJyZW50bHkgY3JlYXRlIGNvbm5lY3RvcnMgKEknZCBsaWtlIHRvIGNoYW5nZSB0 aGF0IGF0Cj4gPiBzb21lIHBvaW50LCBidXQgb25lIHRoaW5nIGF0IGEgdGltZSkgdGhleSBuZWVk IHRvIGNhbGwKPiA+IGRybV9tb2RlX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2RlcigpIGFuZCB0aHVz IG5lZWQgdG8gaGF2ZSBhY2Nlc3MgdG8gdGhlCj4gPiBkcm1fZW5jb2RlciBvYmplY3QgYXQgdGhl IGJlZ2lubmluZyBvZiB0aGUgY2hhaW4uIFRoZSBkcm1fYnJpZGdlIHN0cnVjdHVyZQo+ID4gaGFz IGFuIGVuY29kZXIgZmllbGQsIGl0IHNlZW1zIHRvIG1lIHRoYXQgdGhlIGVhc2llc3QgaXMgdG8g YWx3YXlzCj4gPiBwb3B1bGF0ZSBpdCwgcmVnYXJkbGVzcyBvZiB0aGUgcG9zaXRpb24gb2YgdGhl IGJyaWRnZSBpbiB0aGUgY2hhaW4uCj4gCj4gSSBtZWFuIHRoZSBmdW5jdGlvbiBpbnRlZmFjZSwg bm90IHdoYXQgd2UgZmlsbCBvdXQgaW4gdGhlIGRybV9icmlkZ2UKPiBzdHJ1Y3QuIEkuZS4gaW5z dGVhZCBvZiBleHBlY3RpbmcgY2FsbGVycyB0byBnaXZlIHlvdSB0aGUgZW5jb2RlciBmb3IKPiBj aGFpbmVkIGJyaWRnZXMsIGxvb2sgaXQgdXAgeW91cnNlbGY6Cj4gCj4gCWJyaWRnZS0+ZW5jb2Rl ciA9IHByZXZpb3VzIDogcHJldmlvdXMtPmVuY29kZXIgPyBlbmNvZGVyOwo+IAo+IE9yIHNvbWV0 aGluZyAgbGlrZSB0aGF0LiBKdXN0IGZlZWxzIGNvbmZ1c2luZyB0byBjb25uZWN0IGEgYnJpZGdl IHRvIGJvdGgKPiBhIGJyaWRnZSBfYW5kXyB0aGUgZmlyc3QgZW5jb2Rlci4KClJpZ2h0LiBBcmNo aXQgcHJvcG9zZWQgZG9pbmcgaXQgdGhlIG90aGVyIHdheSBhcm91bmQ6CgogICAgICAgIHByZXZp b3VzID0gZW5jb2Rlci0+YnJpZGdlOwogICAgICAgIHdoaWxlIChwcmV2aW91cyAmJiBwcmV2aW91 cy0+bmV4dCkKICAgICAgICAgICAgICAgIHByZXZpb3VzID0gcHJldmlvdXMtPm5leHQ7CgpUaGF0 IHdvdWxkIHNpbXBsaWZ5IHRoZSBBUEksIGF0IHRoZSBjb3N0IG9mIHByZXZlbnRpbmcgdXMgZnJv bSBjYXRjaGluZyAKZHJpdmVycyB0aGF0IGF0dGFjaCBicmlkZ2VzIGluIHRoZSB3cm9uZyBvcmRl ciAodGhyb3VnaCB0aGUgIXByZXZpb3VzLT5kZXYgCmNoZWNrIHRoYXQgeW91IHN1Z2dlc3RlZCBz aG91bGQgYmUgdHVybmVkIGludG8gYSBXQVJOX09OKS4gVGhlIHByZXZpb3VzLQo+ZW5jb2RlciAh PSBlbmNvZGVyIGNoZWNrIGlzIGFsc28gYSBzYWZldHkgbmV0LgoKQW55IG9waW5pb24gb24gd2hp Y2ggb3B0aW9uIHlvdSBsaWtlIGJldHRlciA/IEknZCBiZSB2ZXJ5IHRlbXB0ZWQgdG8gZ28gZm9y IApBcmNoaXQncyBwcm9wb3NhbCBhcyBpdCByZW1vdmVzIHRoZSBwcmV2aW91cyBwYXJhbWV0ZXIg ZnJvbSB0aGUgQVBJLCBpZiBpdCAKd2Fzbid0IGZvciB0aGUgbG9zcyBvZiBzYW5pdHkgY2hlY2tp bmcuCgo+IFdydCBjcmVhdGluZyB0aGUgY29ubmVjdG9yOiBTb21lIGhlbHBlcnMgdG8gbWFrZSB0 aGF0IGVhc2llciBjb3VsZCBiZQo+IHVzZWZ1bCwgYW5kIHByb2JhYmx5IHdlIG5lZWQgYSBzZXBh cmF0ZSAtPnJlZ2lzdGVyIGNhbGxiYWNrLiBUaGF0J3MgbmVlZGVkCj4gZm9yIHByb3BlciBkZW1p ZGxheWVyZWQgaW5pdC90ZWFyZG93biBzZXF1ZW5jZSBhbnl3YXksIGFuZCB0aGVuIHRoZQo+IGRy bV9icmlkZ2UuYyBjb2RlIG1ha2Ugc3VyZSB0byBvbmx5IGNhbGwgLT5yZWdpc3RlciBmb3IgdGhl IHZlcnkgbGFzdAo+IGJyaWRnZS4gT3RoZXIgYnJpZGdlcyBjb3VsZCBzdGlsbCBjcmVhdGUgdGhl ciBjb25uZWN0b3JzIChsZXNzIGNvbmRpdGlvbnMKPiBpbiB0aGUgY29kZSksIGFzIGxvbmcgYXMg dGhleSBkb24ndCByZWdpc3RlciB0aGVtIG5vIG9uZSB3aWxsIGV2ZXIgc2VlCj4gdGhlbSA7LSkK Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==