From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [RFC] af_packet: support port hotplug Date: Mon, 16 Mar 2015 17:38:36 +0900 Message-ID: <5506968C.4000908@igel.co.jp> References: <1426012584-3614-1-git-send-email-linville@tuxdriver.com> <8CEF83825BEC744B83065625E567D7C2049F26C7@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C2049F282A@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Iremonger, Bernard" Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049F282A-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/03/13 19:14, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org] >> Sent: Friday, March 13, 2015 12:11 AM >> To: Iremonger, Bernard >> Cc: John W. Linville; dev-VfR2kkLFssw@public.gmane.org >> Subject: Re: [dpdk-dev] [RFC] af_packet: support port hotplug >> >> 2015-03-13 2:05 GMT+09:00 Iremonger, Bernard : >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of John W. Linvill= e >>>> Sent: Tuesday, March 10, 2015 6:36 PM >>>> To: dev-VfR2kkLFssw@public.gmane.org >>>> Subject: [dpdk-dev] [RFC] af_packet: support port hotplug >>>> >>>> This patch adds finalization code to free resources allocated by the= >>>> PMD. This is based on earlier patches for other PMDs by Tetsuya >>>> Mukawa , with corrections related to data- >>>>> name. >>>> Signed-off-by: John W. Linville >>>> Cc: Tetsuya Mukawa >>>> --- >>>> lib/librte_pmd_af_packet/rte_eth_af_packet.c | 56 >>>> ++++++++++++++++++++++++++++ >>>> 1 file changed, 56 insertions(+) >>>> >>>> diff --git a/lib/librte_pmd_af_packet/rte_eth_af_packet.c >>>> b/lib/librte_pmd_af_packet/rte_eth_af_packet.c >>>> index 80e9bdf7f819..57998ab19c96 100644 >>>> --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c >>>> +++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c >>>> @@ -399,6 +399,13 @@ static struct eth_dev_ops ops =3D { >>>> .stats_reset =3D eth_stats_reset, }; >>>> >>>> +static struct eth_driver rte_af_packet_pmd =3D { >>>> + .pci_drv =3D { >>>> + .name =3D "rte_af_packet_pmd", >>>> + .drv_flags =3D RTE_PCI_DRV_DETACHABLE, >>>> + }, >>>> +}; >>>> + >>>> /* >>>> * Opens an AF_PACKET socket >>>> */ >>>> @@ -653,6 +660,10 @@ rte_pmd_init_internals(const char *name, >>>> if (*eth_dev =3D=3D NULL) >>>> goto error; >>>> >>>> + /* check length of device name */ >>>> + if ((strlen((*eth_dev)->data->name) + 1) > sizeof(data->name))= >>>> + goto error; >>>> + >>>> /* >>>> * now put it all together >>>> * - store queue data in internals, @@ -669,12 +680,14 @@ >>>> rte_pmd_init_internals(const char *name, >>>> data->nb_tx_queues =3D (uint16_t)nb_queues; >>>> data->dev_link =3D pmd_link; >>>> data->mac_addrs =3D &(*internals)->eth_addr; >>>> + strncpy(data->name, (*eth_dev)->data->name, >>>> +strlen((*eth_dev)->data->name)); >>>> >>>> pci_dev->numa_node =3D numa_node; >>>> >>>> (*eth_dev)->data =3D data; >>>> (*eth_dev)->dev_ops =3D &ops; >>>> (*eth_dev)->pci_dev =3D pci_dev; >>>> + (*eth_dev)->driver =3D &rte_af_packet_pmd; >>>> >>>> return 0; >>>> >>>> @@ -835,10 +848,53 @@ rte_pmd_af_packet_devinit(const char *name, co= nst char *params) >>>> return 0; >>>> } >>>> >>>> +static int >>>> +rte_pmd_af_packet_devuninit(const char *name) { >>>> + struct rte_eth_dev *eth_dev =3D NULL; >>>> + struct pmd_internals *internals; >>>> + struct tpacket_req req; >>>> + >>>> + unsigned q; >>>> + >>>> + RTE_LOG(INFO, PMD, "Closing AF_PACKET ethdev on numa socket %u= \n", >>>> + rte_socket_id()); >>>> + >>>> + if (name =3D=3D NULL) >>>> + return -1; >>> Hi Tetsuya, John, >>> >>> Before detaching a port, the port must be stopped and closed. >>> The stop and close are only allowed for RTE_PROC_PRIMARY. >>> Should there be a check for process_type here? >>> >>> if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) >>> return -EPERM; >>> >>> Regards, >>> >>> Bernard >>> >> Hi Bernard, >> >> I agree with stop() and close() are only called by primary process, bu= t it may not need to add like >> above. >> Could you please check rte_ethdev.c? >> >> - struct rte_eth_dev_data *rte_eth_dev_data; This array is shared betw= een processes. >> So we need to initialize of finalize carefully like you said. >> >> - struct rte_eth_dev rte_eth_devices[] >> This array is per process. >> And 'data' variable of this structure indicates a pointer of rte_eth_d= ev_data. >> >> All PMDs for physical NIC allocates like above when PMDs are initializ= ed. >> (Even when a process is secondary, initialization function of PMDs wil= l be called) But virtual device >> PMDs allocate rte_eth_dev_data and overwrite 'data' >> variable of rte_eth_devices while initialization. >> >> As a result, primary and secondary process has their own 'rte_eth_dev_= data' for a virtual device. >> So I guess all processes need to free it not to leak memory. >> >> Thanks, >> Tetsuya >> > Hi Tetsuya, > > In rte_ethdev.c both rte_eth_dev_stop() and rte_eth_dev_close() use = the macro PROC_PRIMARY_OR_RET(). > So for secondary processes both functions return without doing anythin= g.=20 > Maybe this check should be added to rte_eth_dev_attach() and rte_eth_de= v_detach() ? > > For the Physical/Virtual Functions of the NIC a lot of the finalizati= on is done in the dev->dev_ops->dev_stop() and > dev->dev_ops->dev_close() functions. To complete the finalization the d= ev_uninit() function is called, this should probably do nothing for secon= dary processes as the dev_stop() and dev_close() functions will not have= been executed. Hi Bernard, Sorry for my English. I meant 'virtual device PMD' as PMDs like pcap or af_packet PMDs. Not a PMDs for virtual functions on NIC. For PMDs like a pcap and af_packet PMDs, all data structures are allocated per processes. (Actually I guess nothing is shared between primary and secondary processes, because rte_eth_dev_data is overwritten by each processes.) So we need to free per process data when detach() is called. > For the Physical/Virtual Functions of the NIC the dev_init() is calle= d for both primary and secondary processes, however a subset of the funct= ion only is executed for secondary processes. Because of above, we probably not be able to add PROC_PRIMARY_OR_RET() to rte_eth_dev_detach(). But I agree we should not call rte_eth_dev_detach() for secondary process, if PMDs are like e1000 or ixgbe PMD. To work like above, how about changing drv_flags dynamically in close() callback? For example, when primary process calls rte_eth_dev_close(), a callback of PMD will be called. (In the case of e1000 PMD, eth_em_close() is the callback.) At that time, specify RTE_PCI_DRV_DETACHABLE flag to drv_flag in the callback. It means if primary process hasn't called close() yet, rte_eth_dev_detach() will do nothing and return error. How about doing like above? Regards, Tetsuya > Regards, > > Bernard. > =20 > > > > > >