From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH 02/19] xen/arm: its: Import GICv3 ITS driver from linux Date: Mon, 16 Mar 2015 13:04:15 +0000 Message-ID: <5506D4CF.9040405@linaro.org> References: <1425299435-3278-1-git-send-email-vijay.kilari@gmail.com> <1425299435-3278-3-git-send-email-vijay.kilari@gmail.com> <5502BAF8.1050503@linaro.org> <5502BD79.4010301@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Vijay Kilari Cc: Ian Campbell , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 16/03/15 10:12, Stefano Stabellini wrote: >>> BTW this is not even a copy from Linux. You replaced all the hard tab by >>> space... >> >> Yes, I replaced tabs. Whats the ways of copying linux driver to Xen. >> Should we keep and maintain coding style as well? > > If it is the Linux driver you are importing, then it might be worth > trying to keep it as close to the original as possible so that it won't > be too hard to update in the future. Like Julien has done for the SMMU > driver. Given all the changes made in the driver afterwards, I don't think it would possible to backport patch from Linux. But at least it would help to see the difference during the review of this series. Regards, -- Julien Grall