All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Dave Airlie <airlied@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-gpu/2d: add hardware spec include file
Date: Mon, 16 Mar 2015 12:20:53 -0400	[thread overview]
Message-ID: <550702E5.20801@redhat.com> (raw)
In-Reply-To: <1426240033-24673-3-git-send-email-kraxel@redhat.com>

On 2015-03-13 at 05:47, Gerd Hoffmann wrote:
> This patch adds the header file with structs and defines for
> the virtio based gpu device.  Covers 2d operations only.
>
> Written by Dave Airlie and Gerd Hoffmann.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   include/hw/virtio/virtgpu_hw.h | 203 +++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 203 insertions(+)
>   create mode 100644 include/hw/virtio/virtgpu_hw.h

There are some conflicts with the latest specification I was able to 
obtain 
(https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-gpu.pdf); for 
instance, the ordering of the fields in virtio_gpu_resp_display_info is 
different there, some GPU formats are different (but no conflict), and 
so on.

However, I guess this file will be pretty much the specification for the 
interface, so as long as it makes sense and it compiles, it's correct.

Reviewed-by: Max Reitz <mreitz@redhat.com>

  reply	other threads:[~2015-03-16 16:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  9:47 [Qemu-devel] [PATCH 0/9] add virtio-gpu with 2d support Gerd Hoffmann
2015-03-13  9:47 ` [Qemu-devel] [PATCH] opengl: require glx Gerd Hoffmann
2015-03-13 10:31   ` Gerd Hoffmann
2015-03-13  9:47 ` [Qemu-devel] [PATCH 1/9] virtio-gpu/2d: add hardware spec include file Gerd Hoffmann
2015-03-16 16:20   ` Max Reitz [this message]
2015-03-17  7:54     ` Gerd Hoffmann
2015-03-13  9:47 ` [Qemu-devel] [PATCH 2/9] virtio-gpu/2d: add virtio gpu core code Gerd Hoffmann
2015-03-16 18:28   ` Max Reitz
2015-03-16 20:15   ` Max Reitz
2015-03-17  8:21     ` Gerd Hoffmann
2015-03-13  9:47 ` [Qemu-devel] [PATCH 3/9] virtio-gpu-pci: add virtio pci support Gerd Hoffmann
2015-03-16 18:49   ` Max Reitz
2015-03-13  9:47 ` [Qemu-devel] [PATCH 4/9] virtio-vga: add virtio gpu device with vga compatibility Gerd Hoffmann
2015-03-16 19:17   ` Max Reitz
2015-03-13  9:47 ` [Qemu-devel] [PATCH 5/9] virtio-vga: add '-vga virtio' support Gerd Hoffmann
2015-03-16 19:30   ` Max Reitz
2015-03-13  9:47 ` [Qemu-devel] [PATCH 6/9] virtio-vga: add vgabios configuration Gerd Hoffmann
2015-03-16 19:38   ` Max Reitz
2015-03-13  9:47 ` [Qemu-devel] [PATCH 7/9] virtio-vga: add vgabios binary Gerd Hoffmann
2015-03-16 19:39   ` Max Reitz
2015-03-13  9:47 ` [Qemu-devel] [PATCH 8/9] virtio-gpu: add to display-vga test Gerd Hoffmann
2015-03-16 17:16   ` Paolo Bonzini
2015-03-17  8:25     ` Gerd Hoffmann
2015-03-13  9:47 ` [Qemu-devel] [PATCH 9/9] [hack] virtio-gpu: maskerade as -device VGA Gerd Hoffmann
2015-03-23 20:19 ` [Qemu-devel] [PATCH 0/9] add virtio-gpu with 2d support Christopher Covington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550702E5.20801@redhat.com \
    --to=mreitz@redhat.com \
    --cc=airlied@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.