From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 5/7] xen: make dumping vcpu info look better
Date: Mon, 16 Mar 2015 18:48:25 +0000
Message-ID: <55072579.6020708@eu.citrix.com>
References: <20150316165642.10279.86684.stgit@Solace.station>
	<20150316170527.10279.33227.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150316170527.10279.33227.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Keir Fraser <keir@xen.org>, Meng Xu <xumengpanda@gmail.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 03/16/2015 05:05 PM, Dario Faggioli wrote:
> and more consistent. In fact, before this changes, it looks
> like this:
> 
>  (XEN) VCPU information and callbacks for domain 0:
>  (XEN)     VCPU0: CPU4 [has=F] poll=0 upcall_pend = 00, upcall_mask = 00 dirty_cpus={4} cpu_affinity={0-15}
>  (XEN) cpu_soft_affinity={0-15}
>  (XEN)     pause_count=0 pause_flags=1
>  (XEN)     No periodic timer
> 
> After, it looks like this:
> 
>  (XEN) VCPU information and callbacks for domain 0:
>  (XEN)     VCPU0: CPU4 [has=F] poll=0 upcall_pend=00 upcall_mask=00 dirty_cpus={4}
>  (XEN)     cpu_hard_affinity={0-15} cpu_soft_affinity={0-15}
>  (XEN)     pause_count=0 pause_flags=1
>  (XEN)     No periodic timer
> 
> So, consistently _not_ put space between fields and '=',
> and consistently _not_ use ',' as separator. Also, put the
> info about affinity on the same, properly indented.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Meng Xu <xumengpanda@gmail.com>
> Cc: Jan Beulich <JBeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>

Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>

> ---
>  xen/common/keyhandler.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
> index a917726..5d21e48 100644
> --- a/xen/common/keyhandler.c
> +++ b/xen/common/keyhandler.c
> @@ -294,15 +294,15 @@ static void dump_domains(unsigned char key)
>                  process_pending_softirqs();
>  
>              printk("    VCPU%d: CPU%d [has=%c] poll=%d "
> -                   "upcall_pend = %02x, upcall_mask = %02x ",
> +                   "upcall_pend=%02x upcall_mask=%02x ",
>                     v->vcpu_id, v->processor,
>                     v->is_running ? 'T':'F', v->poll_evtchn,
>                     vcpu_info(v, evtchn_upcall_pending),
>                     !vcpu_event_delivery_is_enabled(v));
>              cpuset_print(tmpstr, sizeof(tmpstr), v->vcpu_dirty_cpumask);
> -            printk("dirty_cpus=%s ", tmpstr);
> +            printk("dirty_cpus=%s\n", tmpstr);
>              cpuset_print(tmpstr, sizeof(tmpstr), v->cpu_hard_affinity);
> -            printk("cpu_affinity=%s\n", tmpstr);
> +            printk("    cpu_hard_affinity=%s ", tmpstr);
>              cpuset_print(tmpstr, sizeof(tmpstr), v->cpu_soft_affinity);
>              printk("cpu_soft_affinity=%s\n", tmpstr);
>              printk("    pause_count=%d pause_flags=%lx\n",
>