From: Florian Fainelli <f.fainelli@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Cc: devicetree@vger.kernel.org, "Kevin Cernekee" <cernekee@gmail.com>,
"Corneliu Doban" <cdoban@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>, "Rafał Miłecki" <zajec5@gmail.com>,
linux-kernel@vger.kernel.org,
"Jonathan Richardson" <jonathar@broadcom.com>,
"Anatol Pomazao" <anatol@google.com>,
bcm-kernel-feedback-list@broadcom.com,
"Dmitry Torokhov" <dtor@google.com>
Subject: Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller
Date: Mon, 16 Mar 2015 12:58:09 -0700 [thread overview]
Message-ID: <550735D1.7030308@gmail.com> (raw)
In-Reply-To: <1425691129-1150-4-git-send-email-computersforpeace@gmail.com>
[snip]
> +static int brcmnand_dma_trans(struct brcmnand_host *host, u64 addr, u32 *buf,
> + u32 len, u8 dma_cmd)
> +{
> + struct brcmnand_controller *ctrl = host->ctrl;
> + dma_addr_t buf_pa;
> + int dir = dma_cmd == CMD_PAGE_READ ? DMA_FROM_DEVICE : DMA_TO_DEVICE;
> +
> + buf_pa = dma_map_single(ctrl->dev, buf, len, dir);
We are missing a dma_mapping_error() check here.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Cc: "Dmitry Torokhov" <dtor@google.com>,
"Anatol Pomazao" <anatol@google.com>,
"Ray Jui" <rjui@broadcom.com>,
"Corneliu Doban" <cdoban@broadcom.com>,
"Jonathan Richardson" <jonathar@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kevin Cernekee" <cernekee@gmail.com>
Subject: Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller
Date: Mon, 16 Mar 2015 12:58:09 -0700 [thread overview]
Message-ID: <550735D1.7030308@gmail.com> (raw)
In-Reply-To: <1425691129-1150-4-git-send-email-computersforpeace@gmail.com>
[snip]
> +static int brcmnand_dma_trans(struct brcmnand_host *host, u64 addr, u32 *buf,
> + u32 len, u8 dma_cmd)
> +{
> + struct brcmnand_controller *ctrl = host->ctrl;
> + dma_addr_t buf_pa;
> + int dir = dma_cmd == CMD_PAGE_READ ? DMA_FROM_DEVICE : DMA_TO_DEVICE;
> +
> + buf_pa = dma_map_single(ctrl->dev, buf, len, dir);
We are missing a dma_mapping_error() check here.
--
Florian
next prev parent reply other threads:[~2015-03-16 19:59 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 1:18 [PATCH 0/3] mtd: nand: add Broadcom NAND controller support Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` [PATCH 1/3] mtd: nand: add common DT init code Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` [PATCH 2/3] Documentation: devicetree: add binding doc for Broadcom NAND controller Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-16 18:49 ` Florian Fainelli
2015-03-16 18:49 ` Florian Fainelli
2015-03-16 23:07 ` Scott Branden
2015-03-16 23:07 ` Scott Branden
2015-03-16 23:07 ` Scott Branden
2015-03-16 23:37 ` Brian Norris
2015-03-16 23:37 ` Brian Norris
2015-03-16 23:37 ` Brian Norris
2015-03-16 23:40 ` Scott Branden
2015-03-16 23:40 ` Scott Branden
2015-03-16 23:40 ` Scott Branden
2015-03-16 23:46 ` Brian Norris
2015-03-16 23:46 ` Brian Norris
2015-03-16 23:52 ` Scott Branden
2015-03-16 23:52 ` Scott Branden
2015-03-16 23:52 ` Scott Branden
2015-03-07 1:18 ` [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB " Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 1:18 ` Brian Norris
2015-03-07 12:39 ` Paul Bolle
2015-03-07 12:39 ` Paul Bolle
2015-03-09 17:30 ` Brian Norris
2015-03-09 17:30 ` Brian Norris
2015-03-07 13:21 ` Rafał Miłecki
2015-03-07 13:21 ` Rafał Miłecki
2015-03-07 13:21 ` Rafał Miłecki
2015-03-09 17:31 ` Brian Norris
2015-03-09 17:31 ` Brian Norris
2015-03-07 17:39 ` Rafał Miłecki
2015-03-07 17:39 ` Rafał Miłecki
2015-03-07 21:48 ` Rafał Miłecki
2015-03-07 21:48 ` Rafał Miłecki
2015-03-07 21:48 ` Rafał Miłecki
2015-03-08 0:44 ` Rafał Miłecki
2015-03-08 0:44 ` Rafał Miłecki
2015-03-09 17:49 ` Brian Norris
2015-03-09 17:49 ` Brian Norris
2015-03-09 17:57 ` Ray Jui
2015-03-09 17:57 ` Ray Jui
2015-03-09 17:57 ` Ray Jui
2015-03-07 22:15 ` Rafał Miłecki
2015-03-07 22:15 ` Rafał Miłecki
2015-03-07 22:15 ` Rafał Miłecki
2015-03-16 18:55 ` Florian Fainelli
2015-03-16 18:55 ` Florian Fainelli
2015-03-16 18:55 ` Florian Fainelli
2015-03-19 1:49 ` Brian Norris
2015-03-19 1:49 ` Brian Norris
2015-03-16 19:58 ` Florian Fainelli [this message]
2015-03-16 19:58 ` Florian Fainelli
2015-03-08 0:01 ` [PATCH 0/3] mtd: nand: add Broadcom NAND controller support Rafał Miłecki
2015-03-08 0:01 ` Rafał Miłecki
2015-03-08 0:57 ` Brian Norris
2015-03-08 0:57 ` Brian Norris
2015-03-08 10:22 ` Rafał Miłecki
2015-03-08 10:22 ` Rafał Miłecki
2015-03-09 18:04 ` Brian Norris
2015-03-09 18:04 ` Brian Norris
2015-03-08 11:18 ` Rafał Miłecki
2015-03-08 11:18 ` Rafał Miłecki
2015-03-08 11:18 ` Rafał Miłecki
2015-03-09 17:59 ` Brian Norris
2015-03-09 17:59 ` Brian Norris
[not found] ` <CALj_zD5rW3Se27Rh0pL6QTMNGOrrmrvAVLvW3BCuF8RujYQE=g@mail.gmail.com>
2015-03-16 23:44 ` Brian Norris
2015-03-16 23:44 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550735D1.7030308@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cdoban@broadcom.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=jonathar@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.