From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXcsK-0005qE-Ul for qemu-devel@nongnu.org; Mon, 16 Mar 2015 17:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXcsH-0001pv-OT for qemu-devel@nongnu.org; Mon, 16 Mar 2015 17:48:40 -0400 Message-ID: <55074FB1.5070607@suse.de> Date: Mon, 16 Mar 2015 17:48:33 -0400 From: Alexander Graf MIME-Version: 1.0 References: <1426346950-7982-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1426346950-7982-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: Add missing checks for NULL pointers and report failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , QEMU Developer Cc: qemu-ppc@nongnu.org On 14.03.15 11:29, Stefan Weil wrote: > This fixes potential runtime crashes and two warnings from Coverity. > > The new error message does not add a prefix "qemu:" because that is > already done in function hw_error. It also starts with an uppercase > letter because that seems to be the mostly used form. > > Signed-off-by: Stefan Weil I've squashed the patch below into your commit as well. Alex diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 9c87a70..7febff7 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1507,7 +1507,7 @@ static void ppc_spapr_init(MachineState *machine) filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin"); if (!filename) { - hw_error("Could not find LPAR rtas '%s'\n", spapr-rtas.bin); + hw_error("Could not find LPAR rtas '%s'\n", "spapr-rtas.bin"); exit(1); } spapr->rtas_size = get_image_size(filename);