From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1YXdGV-0000gi-Sb
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 18:13:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1YXdGQ-0002JM-Sd
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 18:13:39 -0400
Message-ID: <5507557E.2010504@weilnetz.de>
Date: Mon, 16 Mar 2015 23:13:18 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1426346950-7982-1-git-send-email-sw@weilnetz.de>
	<55074FB1.5070607@suse.de>
In-Reply-To: <55074FB1.5070607@suse.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spapr: Add missing checks for NULL
 pointers and report failures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, QEMU Developer <qemu-devel@nongnu.org>
Cc: qemu-ppc@nongnu.org

Am 16.03.2015 um 22:48 schrieb Alexander Graf:
>
> On 14.03.15 11:29, Stefan Weil wrote:
>> This fixes potential runtime crashes and two warnings from Coverity.
>>
>> The new error message does not add  a prefix "qemu:" because that is
>> already done in function hw_error. It also starts with an uppercase
>> letter because that seems to be the mostly used form.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> I've squashed the patch below into your commit as well.
>
>
> Alex
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 9c87a70..7febff7 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1507,7 +1507,7 @@ static void ppc_spapr_init(MachineState *machine)
>
>       filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin");
>       if (!filename) {
> -        hw_error("Could not find LPAR rtas '%s'\n", spapr-rtas.bin);
> +        hw_error("Could not find LPAR rtas '%s'\n", "spapr-rtas.bin");
>           exit(1);
>       }
>       spapr->rtas_size = get_image_size(filename);

I really should not make last minute changes after the build test.

Here I previously had included the filename in the format string,
but then I decided to make the format string identical to the
2nd one and moved the filename out of the string without adding "".

Sorry for the trouble and thank you for the fix.

Stefan