Re: [PATCH 1/3] net: add support for phys_port_name

[David Ahern <dsahern@gmail.com>]

On 3/16/15 10:00 AM, Jiri Pirko wrote:
>> @@ -1159,6 +1168,8 @@ struct net_device_ops {
>> 						      bool new_carrier);
>> 	int			(*ndo_get_phys_port_id)(struct net_device *dev,
>> 							struct netdev_phys_item_id *ppid);
>> +	int			(*ndo_get_phys_port_name)(struct net_device *dev,
>> +							  struct netdev_phys_item_name *name);
>
> I think that we do not need the structure. Just pass "char *name" for buffer
> where to put the name and "size_t len" for len of the buffer. Have:
> #define PORT_NAME_MAX_LEN 32
> and have called to have "char name[PORT_NAME_MAX_LEN]"
>
> Also, given that this is related to switches, won't it make sense to
> push this into switchdev code?


BTW, in regards to the latter comment phys_port_name should stay with 
phys_port_id which is currenly not a switchdev op.

David