From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXoty-0002yi-5m for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:39:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXots-00006T-EZ for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:39:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34259 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXots-00006H-8t for qemu-devel@nongnu.org; Tue, 17 Mar 2015 06:39:04 -0400 Message-ID: <55080445.6020202@suse.de> Date: Tue, 17 Mar 2015 11:39:01 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426583311-29455-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> In-Reply-To: <1426583311-29455-1-git-send-email-chen.fan.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , qemu-devel@nongnu.org Cc: guz.fnst@cn.fujitsu.com, imammedo@redhat.com, zhugh.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, tangchen@cn.fujitsu.com Am 17.03.2015 um 10:08 schrieb Chen Fan: > ICC bus was invented only to provide hotplug capability to > CPU and APIC because at the time being hotplug was available only for > BUS attached devices. >=20 > Now this patch is to drop ICC bus impl, and switch to bus-less > CPU+APIC hotplug, handling them in the same manner as pc-dimm. >=20 > Signed-off-by: Chen Fan > --- > hw/i386/pc.c | 21 +++++---------------- > hw/i386/pc_piix.c | 9 +-------- > hw/i386/pc_q35.c | 9 +-------- > hw/intc/apic.c | 6 +++--- > hw/intc/apic_common.c | 24 +++++++++++++++++++----- > include/hw/i386/apic_internal.h | 5 ++--- > include/hw/i386/pc.h | 2 +- > target-i386/cpu.c | 15 ++------------- > target-i386/cpu.h | 2 +- > 9 files changed, 35 insertions(+), 58 deletions(-) This mini-series is lacking a cover letter and a change log. Please also find a better subject for this one: Luckily you are not just dropping things but rather implementing the new hotplug interface. Is this a resend from Zhu Guihua's series or did anything change? I think for Soft Freeze and Hard Freeze coming up today it's too late. As you may have seen, I've posted a test case to facilitate testing of the various proposed code movements. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)