From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v2 2/4] xen: sched: make counters for vCPU
 sleep and wakeup generic
Date: Tue, 17 Mar 2015 11:12:27 +0000
Message-ID: <55080C1B.5050605@eu.citrix.com>
References: <20150227163925.32500.15985.stgit@Solace.station>
	<20150227165110.32500.78336.stgit@Solace.station>
	<5507105E.2030208@eu.citrix.com> <1426589336.32500.46.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1426589336.32500.46.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, George Dunlap <George.Dunlap@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>, "JBeulich@suse.com" <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 03/17/2015 10:48 AM, Dario Faggioli wrote:
> On Mon, 2015-03-16 at 17:18 +0000, George Dunlap wrote:
>> On 02/27/2015 04:51 PM, Dario Faggioli wrote:
> 
> 
>>> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
>>> index ad0a5d4..2b852cc 100644
>>> --- a/xen/common/sched_credit2.c
>>> +++ b/xen/common/sched_credit2.c
>>> @@ -931,6 +931,7 @@ csched2_vcpu_sleep(const struct scheduler *ops, struct vcpu *vc)
>>>      struct csched2_vcpu * const svc = CSCHED2_VCPU(vc);
>>>  
>>>      BUG_ON( is_idle_vcpu(vc) );
>>> +    SCHED_STAT_CRANK(vcpu_sleep);
>>>  
>>>      if ( per_cpu(schedule_data, vc->processor).curr == vc )
>>>          cpu_raise_softirq(vc->processor, SCHEDULE_SOFTIRQ);
>>> @@ -956,19 +957,22 @@ csched2_vcpu_wake(const struct scheduler *ops, struct vcpu *vc)
>>>  
>>>      BUG_ON( is_idle_vcpu(vc) );
>>>  
>>> -    /* Make sure svc priority mod happens before runq check */
>>>      if ( unlikely(per_cpu(schedule_data, vc->processor).curr == vc) )
>>>      {
>>> +        SCHED_STAT_CRANK(vcpu_wake_running);
>>>          goto out;
>>>      }
>>> -
>>>      if ( unlikely(__vcpu_on_runq(svc)) )
>>
>> Does this make the 'if' butt right up against the '{'?  Is that bad?
>>
>> Other than that:
>>
>> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>>
> As far as I can see, the series is in:
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=8b0e94da0e23221a6d7ea19bfbd24a407db44de8
> 
> and whoever committed it (Jan, probably?), took care of leaving that
> blank line in place, which I'm fine with, of course. :-)

Sweet. :-)

 -George