Re: [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Do not use ggtt_view with (aliasing) PPGTT
Date: Tue, 17 Mar 2015 14:19:18 +0000	[thread overview]
Message-ID: <550837E6.7030802@linux.intel.com> (raw)
In-Reply-To: <1426507873.5166.1.camel@jlahtine-mobl1>

Hi,

On 03/16/2015 12:11 PM, Joonas Lahtinen wrote:
> GGTT views are only applicable when dealing with GGTT. Change the code to
> reject ggtt_view where it should not be used and require it when it should
> be.
>
> v2:
> - Dropped _ppgtt_ infixes, allow both types to be passed
> - Disregard other but normal views when no view is specified
> - More checks that valid parameters are passed
> - More readable error checking
>
> v3:
> - Prefer WARN_ONCE over BUG_ON when there is code path for failure

[snip]

> +unsigned long
> +i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
> +			      enum i915_ggtt_view_type view)
>   {
> +	struct drm_i915_private *dev_priv = o->base.dev->dev_private;

Unused variable slipped through, oops! :)

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx