From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next v4 2/3] newly configured FDB ageing time becomes effective immediately Date: Tue, 17 Mar 2015 17:41:47 +0300 Message-ID: <55083D2B.4050604@cogentembedded.com> References: <80d2d6e6efcafd636712f8bf91c8f002d1d7692d.1426509272.git.siva.mannem.lnx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, sfeldma@gmail.com To: Siva Mannem , netdev@vger.kernel.org Return-path: Received: from mail-la0-f50.google.com ([209.85.215.50]:33780 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbbCQOlv (ORCPT ); Tue, 17 Mar 2015 10:41:51 -0400 Received: by ladw1 with SMTP id w1so10508013lad.0 for ; Tue, 17 Mar 2015 07:41:49 -0700 (PDT) In-Reply-To: <80d2d6e6efcafd636712f8bf91c8f002d1d7692d.1426509272.git.siva.mannem.lnx@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 3/17/2015 2:02 AM, Siva Mannem wrote: > This patch ensures that the newly configured FDB ageing time becomes effective > immediately. It also makes the behavior consistent when the ageing_timer is set > using any of the three existing mechanisms(sysfs, ioctl, netlink). > Signed-off-by: Siva Mannem > Suggested-by: Scott Feldman > --- > net/bridge/br_device.c | 4 ++++ > net/bridge/br_ioctl.c | 3 +-- > net/bridge/br_sysfs_br.c | 8 +------- > 3 files changed, 6 insertions(+), 9 deletions(-) > diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c > index 1a665aa..293a113 100644 > --- a/net/bridge/br_device.c > +++ b/net/bridge/br_device.c > @@ -396,12 +396,16 @@ void br_dev_setup(struct net_device *dev) > int br_set_ageing_time(struct net_bridge *br, unsigned long val) > { > unsigned long t = clock_t_to_jiffies(val); > + unsigned long old_ageing_time; > > if (t < BR_MIN_AGEING_TIME || t > BR_MAX_AGEING_TIME) > return -ERANGE; > > spin_lock_bh(&br->lock); > + old_ageing_time = br->ageing_time; One space is enough after '='... > br->ageing_time = t; > + if (br->ageing_time < old_ageing_time) Isn't it enough to compare just 't' instead of 'br->ageing_time'? > + mod_timer(&br->gc_timer, jiffies); > spin_unlock_bh(&br->lock); > return 0; > } [...] WBR, Sergei