On 3/13/2015 5:37 PM, Bernhard Reutner-Fischer wrote: > On March 13, 2015 10:12:00 PM GMT+01:00, Bernhard Reutner-Fischer wrote: >> On March 13, 2015 8:41:37 PM GMT+01:00, "Woolley, Rob" >> wrote: >>> On 03/12/2015 12:30 PM, Richard Purdie wrote: >>> >>>> Patches 1/2 look good, I've run into the EPIPE issue myself and I >>> have >>>> noticed the crazy logfile so those can likely be merged. >>>> >>>> I'm less sure about 3, letting the user pipe the output to less when >>>> needed would seem to be the better way to have this rather than >>> adding >>>> in specific pagination support? >>>> >>>> Cheers, >>>> >>>> Richard >>> Sounds cool. The exception was bugging me, so I'm glad to hear those >>> ones look good. >>> >>> As far as the 3rd patch is concerned: I remember when I first used >>> bitbake, I was surprised by the flood of data coming from those >>> options. I would suggest that doing the automatic paging provides a >>> better first impression and saves unnecessary typing. >>> >>> I noticed that lib/image/help.py and lib/bsp/help.py have auto-paging >>> for the help command. I've CC'd Tom Zanussi for his opinion. >> Using PAGER is a good thing IMO. >> Not so setting LESS or LV nor outsmarting users PAGER=cat nor >> defaulting to less. >> I would also not attempt to check access() et al, just let the user fix >> her eventually broken export. > PS: > http://comments.gmane.org/gmane.comp.version-control.patchwork/1144 > ;) Thanks for the feedback, Bernhard. I set defaults for LESS and LV based on what git does for its automatic paging: https://github.com/git/git/blob/master/pager.c#L77 The part with cat is also inspired by git: https://github.com/git/git/blob/master/pager.c#L51 I see the first 2 patches went in. I'm going to give the automatic paging patch some more soak time. If anyone is interested in trying it out, I've created a gist for it here: https://gist.github.com/rcwoolley/c662b8e1494c58b1a24d Regards, Rob