Re: [Outreachy kernel] [PATCH] staging: prism2sta: Replace memcpy with ether_add_copy

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/17/15 09:31, Ioana Ciornei wrote:
> Replace memcpy() with ether_addr_copy() when using __aligned(2) Ethernet
> addresses.
> Changes done using the following coccinelle script:
> 
> @@
> expression e1, e2;
> @@
> 
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2); 
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2sta.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This looks good to me!

Jes

> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index 854571f..09fa76b 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -1544,7 +1544,7 @@ static void prism2sta_inf_authreq_defer(wlandevice_t *wlandev,
>  	 ** authentication.
>  	 */
>  
> -	memcpy(rec.address, inf->info.authreq.sta_addr, ETH_ALEN);
> +	ether_addr_copy(rec.address, inf->info.authreq.sta_addr);
>  	rec.status = P80211ENUM_status_unspec_failure;
>  
>  	/*
> @@ -1657,8 +1657,8 @@ static void prism2sta_inf_authreq_defer(wlandevice_t *wlandev,
>  			if (hw->authlist.cnt >= WLAN_AUTH_MAX) {
>  				rec.status = P80211ENUM_status_ap_full;
>  			} else {
> -				memcpy(hw->authlist.addr[hw->authlist.cnt],
> -				       rec.address, ETH_ALEN);
> +				ether_addr_copy(hw->authlist.addr[hw->authlist.cnt],
> +						rec.address);
>  				hw->authlist.cnt++;
>  				added = 1;
>  			}
>