Re: [Outreachy kernel] [PATCH 1/8] Staging: rtl8188eu: Remove parentheses around right side an assignment

[Jes Sorensen <jes.sorensen@gmail.com>]

On 03/13/15 12:55, Haneen Mohammed wrote:
> Parentheses are not needed around the right hand side of an assignment.
> This patch remove parenthese of such occurenses. Issue was detected and
> solved using the following coccinelle script:
> 
> @rule1@
> identifier x, y, z;
> expression E1, E2;
> @@
> 
> (
> x = (y == z);
> |
> x = (E1 == E2);
> |
>  x =
> -(
> ...
> -)
>  ;
> )
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_efuse.c         |  6 +++---
>  drivers/staging/rtl8188eu/core/rtw_ieee80211.c     |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_mlme.c          |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c      | 22 +++++++++++-----------
>  drivers/staging/rtl8188eu/core/rtw_recv.c          |  4 ++--
>  drivers/staging/rtl8188eu/core/rtw_sreset.c        |  2 +-
>  drivers/staging/rtl8188eu/core/rtw_wlan_util.c     | 18 +++++++++---------
>  .../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c   |  4 ++--
>  drivers/staging/rtl8188eu/hal/odm_HWConfig.c       |  2 +-
>  drivers/staging/rtl8188eu/hal/phy.c                | 20 ++++++++++----------
>  drivers/staging/rtl8188eu/hal/rf.c                 |  2 +-
>  11 files changed, 42 insertions(+), 42 deletions(-)

Patch looks good, but there is something weird with your mailer. You are
setting 'Reply-To:' which is a huge no-no, in addition it's pointing to
an invalid email address.

Cheers,
Jes