All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: kdbus: add connection, queue handling and message validation code
Date: Tue, 17 Mar 2015 18:49:38 +0000	[thread overview]
Message-ID: <55087742.5020103@zonque.org> (raw)
In-Reply-To: <20150317182932.GB30354@mwanda>

Hi Dan,

On 03/17/2015 07:29 PM, Dan Carpenter wrote:
> Hello Daniel Mack,
> 
> The patch 5fc8dd5c84fc: "kdbus: add connection, queue handling and
> message validation code" from Sep 11, 2014, leads to the following
> static checker warning:
> 
> 	ipc/kdbus/connection.c:2000 kdbus_cmd_send()
> 	warn: 'cancel_fd' isn't an ERR_PTR
> 
> ipc/kdbus/connection.c
>   1998          if (argv[1].item) {
>   1999                  cancel_fd = fget(argv[1].item->fds[0]);
>                                     ^^^^
> fget() returns NULL on error.

Thanks for reporting this! Should be fixed with the patch I just sent out.


Best regards,
Daniel


  reply	other threads:[~2015-03-17 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 18:29 kdbus: add connection, queue handling and message validation code Dan Carpenter
2015-03-17 18:49 ` Daniel Mack [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-11-21  5:02 [PATCH v2 00/13] Add kdbus implementation Greg Kroah-Hartman
2014-11-21  5:02 ` kdbus: add connection, queue handling and message validation code Greg Kroah-Hartman
2014-10-29 22:00 [PATCH 00/12] Add kdbus implementation Greg Kroah-Hartman
2014-10-29 22:00 ` kdbus: add connection, queue handling and message validation code Greg Kroah-Hartman
     [not found]   ` <87k33iw759.fsf@x220.int.ebiederm.org>
     [not found]     ` <87k33iw759.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2014-10-30  3:55       ` Andy Lutomirski
2014-10-30  3:55         ` Andy Lutomirski
2014-10-30  9:06         ` Djalal Harouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55087742.5020103@zonque.org \
    --to=daniel@zonque.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.