From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH qemu] profiler: Reenable built-in profiler
Date: Tue, 17 Mar 2015 20:29:38 +0100 [thread overview]
Message-ID: <550880A2.4020103@redhat.com> (raw)
In-Reply-To: <1426478258-29961-1-git-send-email-aik@ozlabs.ru>
On 16/03/2015 04:57, Alexey Kardashevskiy wrote:
> 2ed1ebcf6 "timer: replace time() with QEMU_CLOCK_HOST" broke compile
> when configured with --enable-profiler. Turned out the profiler has been
> broken for a while.
>
> This does s/qemu_time/tcg_time/ as the profiler only works in a TCG mode.
> This also fixes the compile error.
>
> This changes profile_getclock() to return nanoseconds rather than
> CPU ticks as the "profile" HMP command prints seconds and there is no
> platform-independent way to get ticks-per-second rate.
> Since TCG is quite slow and get_clock() returns nanoseconds (fine
> enough), this should not affect precision much.
>
> This removes unused qemu_time_start and tlb_flush_time.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Thanks, applied.
Paolo
prev parent reply other threads:[~2015-03-17 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 3:57 [Qemu-devel] [PATCH qemu] profiler: Reenable built-in profiler Alexey Kardashevskiy
2015-03-17 19:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550880A2.4020103@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.