From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-stable <qemu-stable@nongnu.org>,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller
Date: Wed, 18 Mar 2015 15:21:30 +0800 [thread overview]
Message-ID: <5509277A.9030705@huawei.com> (raw)
In-Reply-To: <1426662159.32192.4.camel@nilsson.home.kraxel.org>
On 2015/3/18 15:02, Gerd Hoffmann wrote:
> Hi,
>
>> -static void uhci_reset(void *opaque)
>> +static void uhci_reset(DeviceState *dev)
>> {
>> - UHCIState *s = opaque;
>> + PCIDevice *d = PCI_DEVICE(dev);
>> + UHCIState *s = DO_UPCAST(UHCIState, dev, d);
>
> Uh, oh, DO_UPCAST() is long deprecated. There are other instances of
> this in the uhci emulation though, so we need a cleanup & qom-ify pass
> for the code anyway. So I think it's ok for a bugfix patch.
>
Yes, I noticed that, but I haven't a good idea for qom-ifing uhci. :)
May we refer to the realization of ehci ?
> I'll queue it up (and the other two too of course).
>
Thanks.
Regards,
-Gonglei
next prev parent reply other threads:[~2015-03-18 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 1:49 [Qemu-devel] [PATCH v3 0/3] usb: fix segfault when hot-unplugging usb host adapter arei.gonglei
2015-03-18 1:49 ` [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when hot-unplugging uhci controller arei.gonglei
2015-03-18 7:02 ` Gerd Hoffmann
2015-03-18 7:21 ` Gonglei [this message]
2015-03-18 7:35 ` Markus Armbruster
2015-03-18 7:55 ` Gonglei
2015-03-18 1:49 ` [Qemu-devel] [PATCH v3 2/3] ehci: fix segfault when hot-unplugging ehci controller arei.gonglei
2015-03-18 8:23 ` Gerd Hoffmann
2015-03-18 9:06 ` Gonglei
2015-03-18 1:49 ` [Qemu-devel] [PATCH v3 3/3] ohci: fix resource cleanup leak arei.gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509277A.9030705@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.