From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YY8xt-0008Ts-5X
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 04:04:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YY8xs-0003uY-8I
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 04:04:33 -0400
Message-ID: <55092F7E.9040408@huawei.com>
Date: Wed, 18 Mar 2015 15:55:42 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1426643370-15804-1-git-send-email-arei.gonglei@huawei.com>	<1426643370-15804-2-git-send-email-arei.gonglei@huawei.com>	<1426662159.32192.4.camel@nilsson.home.kraxel.org>
	<871tkmiwq2.fsf@blackfin.pond.sub.org>
In-Reply-To: <871tkmiwq2.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/3] uhci: fix segfault when
 hot-unplugging uhci controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: peter.huangpeng@huawei.com, qemu-stable <qemu-stable@nongnu.org>, qemu-devel@nongnu.org

On 2015/3/18 15:35, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
>>   Hi,
>>
>>> -static void uhci_reset(void *opaque)
>>> +static void uhci_reset(DeviceState *dev)
>>>  {
>>> -    UHCIState *s = opaque;
>>> +    PCIDevice *d = PCI_DEVICE(dev);
>>> +    UHCIState *s = DO_UPCAST(UHCIState, dev, d);
>>
>> Uh, oh, DO_UPCAST() is long deprecated.  There are other instances of
> [...]
> 
> Only 378 instances left in the code %-}
> 
Maybe I can do some cleanup work for 2.4 ;)

Regards,
-Gonglei