From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] i2c: mvtwsi: Fix problem with baud rate calculation
Date: Wed, 18 Mar 2015 10:14:05 +0100 [thread overview]
Message-ID: <550941DD.1020309@denx.de> (raw)
In-Reply-To: <1426667454-9344-1-git-send-email-sr@denx.de>
Hello Stefan,
Am 18.03.2015 09:30, schrieb Stefan Roese:
> The current implementation for baudrate calculation is incorrect.
> This part from the formula:
>
> "2 ^ (n + 1)" is not equivalent to (1 << n) but to (2 << n)!
>
> This patch fixes this and moves this calculation to a function instead of using a macro.
> This new function is taken from the Linux kernel.
>
> This was detected and tested on the Marvell Armada A38x DB-88F6820-GP eval board.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ian Campbell <ijc@hellion.org.uk>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> v2:
> - Still use the old formula for SUNXI, as this was checked
> by Hans with Allwinner to be the correct formula. This means
> that the Linux baudrate is incorrect for SUNXI I2C though.
>
> drivers/i2c/mvtwsi.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Thanks!
Applied to u-boot-i2c.git
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2015-03-18 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:30 [U-Boot] [PATCH v2] i2c: mvtwsi: Fix problem with baud rate calculation Stefan Roese
2015-03-18 8:41 ` Hans de Goede
2015-03-18 9:14 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550941DD.1020309@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.