From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nicholas Mc Guire <hofrat@osadl.org>,
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Cc: linux-wimax@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] wimax/i2400m: fixup completion handling for resetting a device
Date: Wed, 18 Mar 2015 15:29:21 +0300 [thread overview]
Message-ID: <55096FA1.9030908@cogentembedded.com> (raw)
In-Reply-To: <1426585774-24204-1-git-send-email-hofrat@osadl.org>
Hello.
On 3/17/2015 12:49 PM, Nicholas Mc Guire wrote:
> wait_for_completion_timeout return 0 (timeout) or >=1 (completion) so the check
> for > 0 in the else branch is always true and can be dropped. The comment seems
> misleading as it is always going to pass the result up.
> The sync of the completion access with __i2400m_dev_reset_handle (which checks
> for if (i2400m->reset_ctx) could race if i2400m_reset() returns negative so
> the resetting of i2400m->reset_ctx == NULL is moved to the out: path.
> As wait_for_completion_timeout returns unsigned long not int, an appropriately
> named variable of type unsigned long is added and assignments fixed up.
Don't try to do several things in one patch.
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-03-18 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 9:49 [PATCH RFC] wimax/i2400m: fixup completion handling for resetting a device Nicholas Mc Guire
2015-03-18 12:29 ` Sergei Shtylyov [this message]
2015-03-20 7:47 ` Nicholas Mc Guire
2015-03-27 17:19 ` Sergei Shtylyov
2015-03-31 0:44 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55096FA1.9030908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=hofrat@osadl.org \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.