From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>, Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, Neil Brown <neilb@suse.de>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Sage Weil <sage@inktank.com>, Mark Fasheh <mfasheh@suse.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read
Date: Wed, 18 Mar 2015 10:32:57 -0400 [thread overview]
Message-ID: <55098C99.9040104@redhat.com> (raw)
In-Reply-To: <1426687766-518-1-git-send-email-mhocko@suse.cz>
On 03/18/2015 10:09 AM, Michal Hocko wrote:
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 968cd8e03d2e..26f62ba79f50 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1752,7 +1752,7 @@ static int page_cache_read(struct file *file, pgoff_t offset)
> int ret;
>
> do {
> - page = page_cache_alloc_cold(mapping);
> + page = __page_cache_alloc(GFP_KERNEL|__GFP_COLD);
> if (!page)
> return -ENOMEM;
Won't this break on highmem systems, by failing to
allocate the page cache from highmem, where previously
it would?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@suse.cz>, Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, Neil Brown <neilb@suse.de>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Sage Weil <sage@inktank.com>, Mark Fasheh <mfasheh@suse.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read
Date: Wed, 18 Mar 2015 10:32:57 -0400 [thread overview]
Message-ID: <55098C99.9040104@redhat.com> (raw)
In-Reply-To: <1426687766-518-1-git-send-email-mhocko@suse.cz>
On 03/18/2015 10:09 AM, Michal Hocko wrote:
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 968cd8e03d2e..26f62ba79f50 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1752,7 +1752,7 @@ static int page_cache_read(struct file *file, pgoff_t offset)
> int ret;
>
> do {
> - page = page_cache_alloc_cold(mapping);
> + page = __page_cache_alloc(GFP_KERNEL|__GFP_COLD);
> if (!page)
> return -ENOMEM;
Won't this break on highmem systems, by failing to
allocate the page cache from highmem, where previously
it would?
next prev parent reply other threads:[~2015-03-18 14:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 14:09 [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read Michal Hocko
2015-03-18 14:09 ` Michal Hocko
2015-03-18 14:32 ` Rik van Riel [this message]
2015-03-18 14:32 ` Rik van Riel
2015-03-18 14:37 ` Michal Hocko
2015-03-18 14:37 ` Michal Hocko
2015-03-18 14:38 ` Mel Gorman
2015-03-18 14:38 ` Mel Gorman
2015-03-18 14:43 ` Michal Hocko
2015-03-18 14:43 ` Michal Hocko
2015-03-18 14:44 ` Rik van Riel
2015-03-18 14:44 ` Rik van Riel
2015-03-18 14:55 ` Michal Hocko
2015-03-18 14:55 ` Michal Hocko
2015-03-19 7:14 ` Dave Chinner
2015-03-19 7:14 ` Dave Chinner
2015-03-19 11:11 ` [PATCH] mm: Use GFP_KERNEL allocation for the page cache inpage_cache_read Tetsuo Handa
2015-03-19 11:11 ` Tetsuo Handa
2015-03-19 12:44 ` [PATCH] mm: Use GFP_KERNEL allocation for the page cache in page_cache_read Michal Hocko
2015-03-19 12:44 ` Michal Hocko
2015-03-20 3:48 ` Dave Chinner
2015-03-20 3:48 ` Dave Chinner
2015-03-20 13:14 ` Michal Hocko
2015-03-20 13:14 ` Michal Hocko
2015-03-20 22:51 ` Dave Chinner
2015-03-20 22:51 ` Dave Chinner
2015-03-23 13:02 ` Michal Hocko
2015-03-23 13:02 ` Michal Hocko
2015-03-26 9:53 ` Michal Hocko
2015-03-26 9:53 ` Michal Hocko
2015-03-26 21:43 ` Dave Chinner
2015-03-26 21:43 ` Dave Chinner
2015-03-30 8:22 ` Michal Hocko
2015-03-30 8:22 ` Michal Hocko
2015-03-31 21:46 ` Dave Chinner
2015-03-31 21:46 ` Dave Chinner
2015-04-07 12:16 ` Michal Hocko
2015-04-07 12:16 ` Michal Hocko
2015-03-18 15:45 ` Michal Hocko
2015-03-18 15:45 ` Michal Hocko
2015-03-18 21:38 ` NeilBrown
2015-03-19 13:55 ` Michal Hocko
2015-03-19 13:55 ` Michal Hocko
2015-03-19 14:27 ` Michal Hocko
2015-03-19 14:27 ` Michal Hocko
2015-03-20 3:57 ` Dave Chinner
2015-03-20 3:57 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55098C99.9040104@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mfasheh@suse.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=neilb@suse.de \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sage@inktank.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.