From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1YYFKO-0007Et-Df
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:52:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1YYFKL-000160-87
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:52:12 -0400
Received: from david.siemens.de ([192.35.17.14]:59837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1YYF2N-00045S-Ew
	for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:33:35 -0400
Message-ID: <55098CBE.8030003@siemens.com>
Date: Wed, 18 Mar 2015 15:33:34 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1426684909-95030-1-git-send-email-pbonzini@redhat.com>
	<1426684909-95030-7-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1426684909-95030-7-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/8] exec: mark unassigned_io_ops as
	unlocked
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 2015-03-18 14:21, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

A commit log should briefly state why we can do this safely (no state
dependency, no need for locking). Yes, it's trivial in this case but
already a little bit less trivial in case of the PM timer.

> ---
>  exec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/exec.c b/exec.c
> index d60abfc..c1a2e9e 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2197,6 +2197,7 @@ static void memory_map_init(void)
>      system_io = g_malloc(sizeof(*system_io));
>      memory_region_init_io(system_io, NULL, &unassigned_io_ops, NULL, "io",
>                            65536);
> +    memory_region_clear_global_locking(system_io);
>      address_space_init(&address_space_io, system_io, "I/O");
>  
>      memory_listener_register(&core_memory_listener, &address_space_memory);
> 

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux