From: Patrick Farrell <paf@cray.com>
To: <py@amd48-systeme.lip6.fr>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr,
"Pierre-Yves Péneau" <pierre-yves.peneau@gmx.com>,
viro@zeniv.linux.org.uk, aybuke.147@gmail.com,
HPDD-discuss@ml01.01.org
Subject: Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding style
Date: Wed, 18 Mar 2015 14:44:16 -0500 [thread overview]
Message-ID: <5509D590.30207@cray.com> (raw)
In-Reply-To: <5509D291.1060005@cray.com>
Uck, my reply made the formatting even worse. I'm trying to say it
should look like this:
+ rc = ll_intent_file_open(file->f_path.dentry,
+ NULL, 0, it);
Not like this:
+ rc = ll_intent_file_open(file->f_path.dentry,
+ NULL, 0, it);
On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> Perhaps this is just a formatting error in my email client, but
> shouldn't NULL be one more space over to line up with the '(' above?
>
> On 03/18/2015 02:08 PM, py@amd48-systeme.lip6.fr wrote:
>> + rc = ll_intent_file_open(file->f_path.dentry,
>> + NULL, 0, it);
>
> _______________________________________________
> HPDD-discuss mailing list
> HPDD-discuss@lists.01.org
> https://lists.01.org/mailman/listinfo/hpdd-discuss
next prev parent reply other threads:[~2015-03-18 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:08 [PATCH] Staging: lustre: file.c: fix coding style py
2015-03-18 19:31 ` [HPDD-discuss] " Patrick Farrell
2015-03-18 19:44 ` Patrick Farrell [this message]
2015-03-18 22:46 ` Julia Lawall
2015-03-18 19:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509D590.30207@cray.com \
--to=paf@cray.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=aybuke.147@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-yves.peneau@gmx.com \
--cc=py@amd48-systeme.lip6.fr \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.