From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Jan Vesely <jan.vesely@rutgers.edu>,
Emil Velikov <emil.l.velikov@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 1/1] tests/exynos: Fix warnings
Date: Wed, 18 Mar 2015 21:17:10 +0100 [thread overview]
Message-ID: <5509DD46.4080807@math.uni-bielefeld.de> (raw)
In-Reply-To: <1426707716.3949.13.camel@rutgers.edu>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jan Vesely wrote:
>>
>>> @@ -573,6 +573,7 @@ static int g2d_checkerboard_test(struct
>>> exynos_device *dev, src_img.user_ptr[0].userptr = (unsigned
>>> long)checkerboard; src_img.user_ptr[0].size = img_w * img_h *
>>> 4; break; + case G2D_IMGBUF_COLOR: default: ret = -EFAULT; goto
>>> fail;
>>>
>> Hmm, I don't see the reason why this label should be added to the
>> switch statement?
>
> This is mostly to appease the compiler. -Wswitch-enum warns about
> missing enumeration cases even if default is present. On the other
> hand it also warns against branches that use values outside of the
> enumeration (which might be useful).
Ah, that makes sense. I guess adding the label is a good thing then!
With best wishes,
Tobias
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlUJ3UYACgkQ6bCODwikBXd6xgCdG4sZERoY6KalhPn6AhyoxfbO
8EQAnRrCZrPXN/fjqwZT4X6a/7wLofeJ
=C/FO
-----END PGP SIGNATURE-----
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-18 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:30 [PATCH libdrm 1/1] tests/exynos: Fix warnings Jan Vesely
2015-03-18 19:23 ` Tobias Jakobi
2015-03-18 19:41 ` Jan Vesely
2015-03-18 20:17 ` Tobias Jakobi [this message]
2015-03-20 17:43 ` Emil Velikov
2015-03-20 22:12 ` Jan Vesely
2015-03-20 22:14 ` Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509DD46.4080807@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jan.vesely@rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.