All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: maps mismatch in /proc/kcore for sparc
Date: Wed, 18 Mar 2015 21:22:37 +0000	[thread overview]
Message-ID: <5509EC9D.2060506@oracle.com> (raw)
In-Reply-To: <20150318.161403.1392052398222912621.davem@davemloft.net>

On 3/18/15 2:14 PM, David Miller wrote:
> Oh I see, you're using older sources which don't have:
>
> 	commit abaf3787ac26ba33e2f75e76b1174c32254c25b0
> 	Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> 	Date:   Thu Jan 23 15:55:45 2014 -0800
>
> 	    fs/proc: don't use module_init for non-modular core code

Interesting.

# git describe abaf3787ac26ba33e2f75e76b1174c32254c25b0
v3.13-4322-gabaf3787ac26

I am running 3.18 and that patch has been applied to the tree.

Looking at 4.0.0-rc3 and I do see the 0-length problem. Perhaps another 
defect is the root cause?

Regardless the below works.

David

>
> And that explains everything, I'll submit the following:
>
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index 96ac69c..efb00ec 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -86,6 +86,9 @@ config ARCH_DEFCONFIG
>   	default "arch/sparc/configs/sparc32_defconfig" if SPARC32
>   	default "arch/sparc/configs/sparc64_defconfig" if SPARC64
>
> +config ARCH_PROC_KCORE_TEXT
> +	def_bool y
> +
>   config IOMMU_HELPER
>   	bool
>   	default y if SPARC64
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index 3ea267c..4ca0d6b 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -2820,7 +2820,7 @@ static int __init report_memory(void)
>
>   	return 0;
>   }
> -device_initcall(report_memory);
> +arch_initcall(report_memory);
>
>   #ifdef CONFIG_SMP
>   #define do_flush_tlb_kernel_range	smp_flush_tlb_kernel_range
>


WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <david.ahern@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: maps mismatch in /proc/kcore for sparc
Date: Wed, 18 Mar 2015 15:22:37 -0600	[thread overview]
Message-ID: <5509EC9D.2060506@oracle.com> (raw)
In-Reply-To: <20150318.161403.1392052398222912621.davem@davemloft.net>

On 3/18/15 2:14 PM, David Miller wrote:
> Oh I see, you're using older sources which don't have:
>
> 	commit abaf3787ac26ba33e2f75e76b1174c32254c25b0
> 	Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> 	Date:   Thu Jan 23 15:55:45 2014 -0800
>
> 	    fs/proc: don't use module_init for non-modular core code

Interesting.

# git describe abaf3787ac26ba33e2f75e76b1174c32254c25b0
v3.13-4322-gabaf3787ac26

I am running 3.18 and that patch has been applied to the tree.

Looking at 4.0.0-rc3 and I do see the 0-length problem. Perhaps another 
defect is the root cause?

Regardless the below works.

David

>
> And that explains everything, I'll submit the following:
>
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index 96ac69c..efb00ec 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -86,6 +86,9 @@ config ARCH_DEFCONFIG
>   	default "arch/sparc/configs/sparc32_defconfig" if SPARC32
>   	default "arch/sparc/configs/sparc64_defconfig" if SPARC64
>
> +config ARCH_PROC_KCORE_TEXT
> +	def_bool y
> +
>   config IOMMU_HELPER
>   	bool
>   	default y if SPARC64
> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
> index 3ea267c..4ca0d6b 100644
> --- a/arch/sparc/mm/init_64.c
> +++ b/arch/sparc/mm/init_64.c
> @@ -2820,7 +2820,7 @@ static int __init report_memory(void)
>
>   	return 0;
>   }
> -device_initcall(report_memory);
> +arch_initcall(report_memory);
>
>   #ifdef CONFIG_SMP
>   #define do_flush_tlb_kernel_range	smp_flush_tlb_kernel_range
>


  reply	other threads:[~2015-03-18 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 16:56 maps mismatch in /proc/kcore for sparc David Ahern
2015-03-18 16:56 ` David Ahern
2015-03-18 19:43 ` David Miller
2015-03-18 19:43   ` David Miller
2015-03-18 19:57   ` David Ahern
2015-03-18 19:57     ` David Ahern
2015-03-18 20:14     ` David Miller
2015-03-18 20:14       ` David Miller
2015-03-18 21:22       ` David Ahern [this message]
2015-03-18 21:22         ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5509EC9D.2060506@oracle.com \
    --to=david.ahern@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.