From: John Snow <jsnow@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls
Date: Wed, 18 Mar 2015 18:55:33 -0400 [thread overview]
Message-ID: <550A0265.80806@redhat.com> (raw)
In-Reply-To: <CAFEAcA9py8XFAZ08=kV0QYVbNZQDc+=64DBR+37kPpvJQEB6ZA@mail.gmail.com>
On 03/18/2015 06:51 PM, Peter Maydell wrote:
> On 18 March 2015 at 22:43, John Snow <jsnow@redhat.com> wrote:
>> Calling abs() on a uint32_t is a no-op, so remove it.
>> clang 3.5.0 will not compile this if -Werror is set,
>> throwing a -Wabsolute-value warning.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> This is probably the wrong fix (ie it silences the
> warning rather than fixing the bug). See
> http://patchwork.ozlabs.org/patch/447585/
>
> thanks
> -- PMM
>
Ah, I missed that there was another patch out there and a deeper bug. I
thought this was a harmless abs() inclusion, but I didn't look too
deeply at it.
I am fine with dropping this patch if a more comprehensive change is in
the works, but the other three should still stand.
--js
next prev parent reply other threads:[~2015-03-18 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 22:43 [Qemu-devel] [PATCH v2 0/4] configure: clang 3.5.0 build fixes John Snow
2015-03-18 22:43 ` [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls John Snow
2015-03-18 22:51 ` Peter Maydell
2015-03-18 22:55 ` John Snow [this message]
2015-03-18 22:43 ` [Qemu-devel] [PATCH v2 2/4] configure: handle clang -nopie argument warning John Snow
2015-03-18 22:43 ` [Qemu-devel] [PATCH v2 3/4] configure: silence glib unknown attribute __alloc_size__ John Snow
2015-03-18 22:55 ` Peter Maydell
2015-03-18 22:43 ` [Qemu-devel] [PATCH v2 4/4] configure: Add workaround for ccache and clang John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550A0265.80806@redhat.com \
--to=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.