From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors Date: Thu, 19 Mar 2015 10:29:11 +0200 Message-ID: <550A88D7.8050804@amd.com> References: <1426181020-2344-1-git-send-email-john.stultz@linaro.org> <3959463.EVBM1FXcuD@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0102.outbound.protection.outlook.com [65.55.169.102]) by gabe.freedesktop.org (Postfix) with ESMTP id 906BC6E25A for ; Thu, 19 Mar 2015 01:29:25 -0700 (PDT) In-Reply-To: <3959463.EVBM1FXcuD@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , John Stultz Cc: lkml , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAwMy8xMy8yMDE1IDAxOjI0IFBNLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+IE9uIFRodXJz ZGF5IDEyIE1hcmNoIDIwMTUgMTA6MjM6NDAgSm9obiBTdHVsdHogd3JvdGU6Cj4+IENvbnZlcnQg dGhlIHRpbWVzdGFtcGluZyBpbiB0aGUgYW1ka2ZkIGRyaXZlciB0byB1c2UKPj4gYSB0aW1lc3Bl YzY0IGFuZCA2NGJpdCB0aW1lIGFjY2Vzc29ycy4KPj4KPj4gQ2M6IEFybmQgQmVyZ21hbm4gPGFy bmRAYXJuZGIuZGU+Cj4+IENjOiBPZGVkIEdhYmJheSA8b2RlZC5nYWJiYXlAYW1kLmNvbT4KPj4g Q2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPj4gQ2M6IGRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPj4gU2lnbmVkLW9mZi1ieTogSm9obiBTdHVsdHogPGpvaG4uc3R1 bHR6QGxpbmFyby5vcmc+Cj4+Cj4KPiBUaGUgcGF0Y2ggbG9va3MgZ29vZCwgYnV0IEknZCBhbHdh eXMgaW5jbHVkZSBhdCBsZWFzdCBhIG9uZS1saW5lcgo+IGFib3V0IHdoYXQgaXQncyBnb29kIGZv ci4gSW4gdGhpcyBjYXNlLCB0aGUgZXhpc3RpbmcgY29kZQo+IGlzIGNvbXBsZXRlbHkgc2FmZSBi ZXlvbmQgeTIwMzggYmVjYXVzZSB5b3UgYXJlIGRlYWxpbmcgd2l0aAo+IG1vbm90b25pYyB0aW1l LCBzbyBpdCdzIHdvcnRoIG1lbnRpb25pbmcgdGhhdCB3ZSBkbyB0aGlzIGluCj4gb3JkZXIgdG8g a2lsbCBvZmYgYWxsIHVzZXMgb2Ygc3RydWN0IHRpbWVzcGVjLgo+Cj4gCUFybmQKPgpUaGFua3Mh CkFwcGxpZWQgdG8gbXkgLW5leHQgdHJlZSBzbyB3aWxsIHByb2JhYmx5IGJlIGluIDQuMQoKCU9k ZWQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbCSI3c (ORCPT ); Thu, 19 Mar 2015 04:29:32 -0400 Received: from mail-bl2on0104.outbound.protection.outlook.com ([65.55.169.104]:6781 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750993AbbCSI30 (ORCPT ); Thu, 19 Mar 2015 04:29:26 -0400 X-WSS-ID: 0NLGA8V-08-CLL-02 X-M-MSG: Message-ID: <550A88D7.8050804@amd.com> Date: Thu, 19 Mar 2015 10:29:11 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Arnd Bergmann , John Stultz CC: lkml , David Airlie , Subject: Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors References: <1426181020-2344-1-git-send-email-john.stultz@linaro.org> <3959463.EVBM1FXcuD@wuerfel> In-Reply-To: <3959463.EVBM1FXcuD@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.0.84] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Oded.Gabbay@amd.com; arndb.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(189002)(479174004)(199003)(377454003)(41574002)(51704005)(24454002)(83506001)(105586002)(33656002)(23746002)(106466001)(64126003)(50466002)(19580405001)(80316001)(19580395003)(101416001)(87936001)(46102003)(36756003)(92566002)(86362001)(2950100001)(65806001)(65956001)(47776003)(62966003)(77156002)(54356999)(87266999)(76176999)(65816999)(50986999)(77096005)(3940600001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0201MB0889;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0889; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:CY1PR0201MB0889;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0889; X-Forefront-PRVS: 052017CAF1 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2015 08:29:23.1044 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0889 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2015 01:24 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 10:23:40 John Stultz wrote: >> Convert the timestamping in the amdkfd driver to use >> a timespec64 and 64bit time accessors. >> >> Cc: Arnd Bergmann >> Cc: Oded Gabbay >> Cc: David Airlie >> Cc: dri-devel@lists.freedesktop.org >> Signed-off-by: John Stultz >> > > The patch looks good, but I'd always include at least a one-liner > about what it's good for. In this case, the existing code > is completely safe beyond y2038 because you are dealing with > monotonic time, so it's worth mentioning that we do this in > order to kill off all uses of struct timespec. > > Arnd > Thanks! Applied to my -next tree so will probably be in 4.1 Oded