From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYaUA-00048V-OY for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:27:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYaU7-0003KK-Jb for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:27:42 -0400 Received: from goliath.siemens.de ([192.35.17.28]:59899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYaU7-0003K1-9T for qemu-devel@nongnu.org; Thu, 19 Mar 2015 09:27:39 -0400 Message-ID: <550ACEC8.5030701@siemens.com> Date: Thu, 19 Mar 2015 14:27:36 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1426684909-95030-1-git-send-email-pbonzini@redhat.com> <1426684909-95030-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1426684909-95030-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/8] exec: move rcu_read_lock/unlock to address_space_translate callers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 2015-03-18 14:21, Paolo Bonzini wrote: > @@ -2591,9 +2596,12 @@ void *address_space_map(AddressSpace *as, > } > > l = len; > + rcu_read_lock(); > mr = address_space_translate(as, addr, &xlat, &l, is_write); > + > if (!memory_access_is_direct(mr, is_write)) { > if (atomic_xchg(&bounce.in_use, true)) { Doesn't apply due to differences in the line above. What is this patch based on? Do you have a public branch where I can find the series and its dependencies? > + rcu_read_unlock(); > return NULL; > } > /* Avoid unbounded allocations */ Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux