From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCHv1] xen/balloon: disable memory hotplug in PV guests Date: Thu, 19 Mar 2015 15:21:18 +0100 Message-ID: <550ADB5E.5070209@suse.com> References: <5500544B.4020302@citrix.com> <550061F0.9030206@oracle.com> <55066B88.9040300@suse.com> <20150316100344.GV27971@olila.local.net-space.pl> <5506B115.8090804@suse.com> <5509553A.7030707@citrix.com> <5509843B.2080205@suse.com> <550984DE.4010800@citrix.com> <20150318151424.GB27971@olila.local.net-space.pl> <550A9D19.9040800@suse.com> <20150319113453.GC27971@olila.local.net-space.pl> <550AD151.20302@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYbK6-0001Rf-Et for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 14:21:22 +0000 In-Reply-To: <550AD151.20302@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: xen-devel@lists.xenproject.org, Daniel Kiper , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 03/19/2015 02:38 PM, Juergen Gross wrote: > On 03/19/2015 12:34 PM, Daniel Kiper wrote: >> On Thu, Mar 19, 2015 at 10:55:37AM +0100, Juergen Gross wrote: >>> On 03/18/2015 04:14 PM, Daniel Kiper wrote: >> >> [...] >> >>>> I have checked new p2m code and I think that this is reasonable >>>> solution too. >>> >>> Do I need any patches for xl to be able to test this? I did: >>> >>> xl mem-max 2 4096 >>> xl mem-set 2 4096 >> >> Yep. I started work on it but I was not able to finish it. >> Here you can find some old patches for this issue: >> >> http://lists.xen.org/archives/html/xen-devel/2013-04/msg03072.html >> >> Bob and I will work on it sooner or later (probably a bit later). >> >> Hmmm... Boris, David, how did you manage to get this memory hotplug >> stuff working. Did you use xm instead of xl? > > Whoever can test this - what about the attached patch? Already succeeded in testing. :-) Rather easy via: Dom0: xl mem-max DomU: echo >/sys/devices/system/xen_memory/xen_memory0/target_kb On my system udev is set up to add the memory automatically, so no further action required for me. > David, you said: > > This one can be trivially fixed by setting the new sections in the p2m > to INVALID_P2M_ENTRY before calling add_memory(). > > Are you preparing a patch for this, or do you want me to do it? I've already got a patch working, I'll send it soon. Juergen