From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: famz@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class
Date: Thu, 19 Mar 2015 08:22:06 -0600 [thread overview]
Message-ID: <550ADB8E.3060908@redhat.com> (raw)
In-Reply-To: <20150319112954.GB3845@noname.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On 03/19/2015 05:29 AM, Kevin Wolf wrote:
> Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben:
>> Error classes are a leftover from the days of "rich" error objects.
>> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit
>> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace
>> them.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Thanks, applied to the block branch.
>
> Eric, please speak up if libvirt needs the error code for any of these.
Libvirt is not using blockdev-backup yet, and so by implication does not
care about the error class.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-03-19 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 7:36 [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class Markus Armbruster
2015-03-17 7:49 ` Markus Armbruster
2015-03-19 11:29 ` Kevin Wolf
2015-03-19 11:51 ` Markus Armbruster
2015-03-19 14:22 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550ADB8E.3060908@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.