Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert tests

[Max Reitz <mreitz@redhat.com>]

On 2015-03-19 at 10:41, Max Reitz wrote:
> On 2015-02-18 at 10:19, Kevin Wolf wrote:
>> This adds a regression test for some problems that the qemu-img convert
>> rewrite just fixed.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>   tests/qemu-iotests/122     | 83 
>> ++++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/122.out | 30 +++++++++++++++++
>>   tests/qemu-iotests/group   |  1 +
>>   3 files changed, 114 insertions(+)
>>   create mode 100755 tests/qemu-iotests/122
>>   create mode 100644 tests/qemu-iotests/122.out
>
> [snip]
>
>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
>> index 4b2b93b..28c78e5 100644
>> --- a/tests/qemu-iotests/group
>> +++ b/tests/qemu-iotests/group
>> @@ -117,3 +117,4 @@
>>   113 rw auto quick
>>   114 rw auto quick
>>   116 rw auto quick
>> +122 rw auto quick
>
> This test takes 17 s on my HDD, and 7 s in tmpfs. Are you sure it 
> should be added to the "quick" group?
>
> Other than that, looks good.
>
> Max

Argh, disregard that, I had the wrong version open. Sorry.

Max