Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert tests

[Max Reitz <mreitz@redhat.com>]

On 2015-03-19 at 10:44, Max Reitz wrote:
> On 2015-03-19 at 08:33, Kevin Wolf wrote:
>> This adds a regression test for some problems that the qemu-img convert
>> rewrite just fixed.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>   tests/qemu-iotests/122     | 223 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/122.out | 209 
>> ++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/group   |   1 +
>>   3 files changed, 433 insertions(+)
>>   create mode 100755 tests/qemu-iotests/122
>>   create mode 100644 tests/qemu-iotests/122.out
>
> [snip]
>
>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
>> index 6262127..7c20ace 100644
>> --- a/tests/qemu-iotests/group
>> +++ b/tests/qemu-iotests/group
>> @@ -122,5 +122,6 @@
>>   115 rw auto
>>   116 rw auto quick
>>   121 rw auto
>> +122 rw auto quick
>>   123 rw auto quick
>>   128 rw auto quick
>
> As I mistakenly replied to v2 just now, this test takes 17 s on my 
> HDD, and 7 s in tmpfs. So are you sure it should be added to the 
> "quick" group?

*v1... I somehow don't seem too awake today.

> The test itself looks good, though.
>
> Max