All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: "Hefty, Sean" <sean.hefty@intel.com>,
	Roland Dreier <roland@kernel.org>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Or Gerlitz <ogerlitz@mellanox.com>,
	"Weiny, Ira" <ira.weiny@intel.com>,
	Moni Shoua <monis@mellanox.com>,
	"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Yan Burman <yanb@mellanox.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Bart Van Assche <bvanassche@acm.org>,
	Yann Droneaud <ydroneaud@opteya.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Estrin, Alex" <alex.estrin@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Erez Shitrit <erezsh@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Sagi Grimberg <sagig@mellanox.com>,
	Shachar Raindel <raindel@mellanox.com>,
	Eli Cohen <eli@dev.mellanox.co.il>,
	Matan Barak <matanb@mellanox.com>,
	"Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Subject: Re: [PATCH RFC] IB/verbs: introduce rdma_transport_is_ib() to check transport type
Date: Thu, 19 Mar 2015 18:29:36 +0100	[thread overview]
Message-ID: <550B0780.9040406@profitbricks.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237399E821EA@ORSMSX109.amr.corp.intel.com>

Hi, Sean

Thanks for point it out for me :-)

I'll try to follow the conversation to understand what
really needs to be done, see if I could do some
contribution on it.

Regards,
Michael Wang

On 03/19/2015 06:02 PM, Hefty, Sean wrote:
>> We have plenty of places where we don't care what exactly the
>> transport type is, but only care if it's IB type.
>>
>> This patch introduce rdma_transport_is_ib() as shortcuts to check
>> whether an 'ib_device' is infiniband transport type, which help us to
>> save some code.
> In most of these places, the check that we want is whether IB management is used.  The transport check is an indirect way of checking for that, and I believe we should use a more direct method of checking for the functionality that's actually desired.
>
> Please see the following thread that is related to these changes:
>
> http://www.spinics.net/lists/linux-rdma/msg23484.html
>
> - Sean

      reply	other threads:[~2015-03-19 17:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 13:44 [PATCH RFC] IB/verbs: introduce rdma_transport_is_ib() to check transport type Michael Wang
2015-03-19 13:44 ` Michael Wang
2015-03-19 17:02 ` Hefty, Sean
2015-03-19 17:02   ` Hefty, Sean
2015-03-19 17:29   ` Michael Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550B0780.9040406@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=alex.estrin@intel.com \
    --cc=bvanassche@acm.org \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=edumazet@google.com \
    --cc=eli@dev.mellanox.co.il \
    --cc=erezsh@mellanox.com \
    --cc=haggaie@mellanox.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matanb@mellanox.com \
    --cc=mike.marciniszyn@intel.com \
    --cc=monis@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=raindel@mellanox.com \
    --cc=roland@kernel.org \
    --cc=sagig@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tatyana.e.nikolova@intel.com \
    --cc=yanb@mellanox.com \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.